ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.36k stars 271 forks source link

bug (YouTube/`Hide horizontal shelves`): Watch it again shelf showing up in home #3037

Closed ILoveOpenSourceApplications closed 6 months ago

ILoveOpenSourceApplications commented 6 months ago

Bug description

Patching with the latest dev release, I'm still coming across the Watch it again shelf in my home page.

Screenshots

![Screenshot_20240418_133058_YouTube](https://github.com/ReVanced/revanced-patches/assets/117499019/acc91b82-64bc-474f-a951-e821cc46aae5) ![Screenshot_20240418_133106_YouTube](https://github.com/ReVanced/revanced-patches/assets/117499019/db1de7ae-b015-477f-ab08-bfec6b63b047) ![Screenshot_20240418_133202_YouTube](https://github.com/ReVanced/revanced-patches/assets/117499019/714e3f9f-03de-4ffa-b8c0-6be8172f9624)

Error logs

04-18 13:11:20.242  6835  8750 D revanced: LithoFilterPatch: Searching ID: null Path: horizontal_tile_shelf.eml|9e1745388784a25b|CellType|ContainerType|shelf_header.eml|ed1d930066a885e4|CellType|modern_type_shelf_header_content.eml|aabd4b51dd8753ab|ContainerType|ContainerType|ContainerType| BufferStrings: overflow_button.eml|4a62de6504bacb26Γ¥ÖWatch it againΓ¥Ösans-serifΓ¥Öeml.shelf_headerΓ¥ÖWatch it againΓ¥ÖFEhistoryΓ¥Ö
04-18 13:11:20.242  6835  8750 D revanced: LithoFilterPatch: Searching ID: null Path: horizontal_tile_shelf.eml|9e1745388784a25b|CellType|ContainerType|shelf_header.eml|ed1d930066a885e4
04-18 13:36:41.506 14144 14321 D revanced: LithoFilterPatch: Searching ID: null Path: horizontal_tile_shelf.eml|9e1745388784a25b|CellType|ContainerType|CollectionType|video_card.eml|f8a5acf2c8df98f6|CellType|video_card_content.eml|1d2767368fdb9ffa|ContainerType|ContainerType|ContainerType| BufferStrings: video-card-cellΓ¥Öoverflow_button.eml|4a62de6504bacb26Γ¥Ömetadata.eml|a6c182a616b1aaa8Γ¥Öthumbnail.eml|95afd0bc59efca48Γ¥Öeml.video_cardΓ¥ÖPlay nextΓ¥ÖYlM2TGMaEKQ*Γ¥ÖAdd to Γ¥ÖQueueΓ¥ÖYlM2TGMaEKQ*Γ¥ÖPlay next in queueΓ¥ÖSPunlimitedΓ¥Ö2kgMgEg9GRXdoYXRfdG9fd2F0Y2hKDQgGEgl1bmxpbWl0ZWQ%3D"Γ¥Ö/premium*Γ¥ÖSave to Watch laterΓ¥ÖYlM2TGMaEKQ0Γ¥ÖEgtZbE0yVEdNYUVLUSDnASgBΓ¥ÖEgtZbE0yVEdNYUVLUSDnASgBΓ¥ÖSave to playlistΓ¥ÖPAadd_to_playlistΓ¥Ö-gYNCgtZbE0yVEdNYUVLUQ%3D%3D*Γ¥ÖSave to playlistΓ¥ÖYlM2TGMaEKQΓ¥ÖMedium (360p)Γ¥ÖLow (144p)Γ¥ÖofflinelistJΓ¥Öhttps://ad.doubleclick.net/ddm/activity/src=2542116;type=youtu444;cat=ytmob00;dc_rdid=[DEVICE_ADVERTISER_ID_FOR_CONVERSION_TRACKING];tag_for_child_directed_treatment=;ord=65609Γ¥ÖYlM2TGMaEKQ*Γ¥ÖCAI%3D*Γ¥ÖShareΓ¥Öss_FTpIm9YoL1IxdpXT*]Γ¥ÖCgtZbE0yVEdNYUVLUQ%3D%3DΓ¥Öss_FTpIm9YoL1IxdpXTJΓ¥ÖNot interestedΓ¥ÖAB9zfpJxJWqJ_9ZhHW7xMNU_HbRY1_5oK9bD6xmDquzhXOf4yDDxrNODcLZS3ymkXNE_3K9SL1SbvjIyxeEO7s790XU-Qd8pPmoYuDamUxqvHC-tweUcS4Qy2YwlEHTkQq0vM-oFnm0IWWbcfNTO3K2QebWTIWzxXwΓ¥ÖYlM2TGMaEKQΓ¥ÖVideo removedΓ¥Ö9Video removed: DarkViperAU's Reddit Recap - October 2023.*Γ¥ÖDon't recommend channelΓ¥ÖAB9zfpIwcOmghD6bF9ZWcCKYssfCYoWvL8K5cqG1KvKX_FS884kilfzJWPC8rJbDlPvgQi4T8LKY1mI95xTKyoM0cdCujlutUz2EAO9ihXUpMzO31X73P4PYnJ9ZLPRjfFLFYOoUvzqadZm0kjgsrO_ItB5m0K9qBdLuQssBz0TLGTbTdRWrSMbn0ZEjzTVLB8QRQZ6zzIMPΓ¥ÖYlM2TGMaEKQΓ¥Ö8We won't recommend videos from this channel to you again*Γ¥ÖReportΓ¥Ö$EgtZbE0yVEdNYUVLUUABWABwAXgC2AEB6AEA*Γ¥Ö9Action menu for DarkViperAU's Reddit Recap - October 2023Γ¥Ög-high-cpwZΓ¥ÖFEwhat_to_watchΓ¥ÖYlM2TGMaEKQΓ¥Öhttps://rr3---sn-5np5oxu-jv3l.googlevideo.com/initplayback?source=youtube&oeis=1&c=ANDROID&oad=7000&ovd=7000&oaad=11000&oavd=11000&ocs=550&oewis=1&ohct=2&oaf1=1&oputc=1&ofpcc=2&siu=1&obbl=24576&msp=1&odepv=1&id=6253364c631a10a4&ip=202.164.139.197&initcwndbps=1157500&mt=1713426284Γ¥ÖL?]fff?`2hΓ¥ÖOMX.ffmpeg.vp9.decoderΓ¥ÖOMX.google.vp9.decoderΓ¥Öc2.android.vp9.decoderΓ¥ÖOMX.Intel.sw_vd.vp9Γ¥ÖOMX.MTK.VIDEO.DECODER.SW.VP9Γ¥Öc2.mtk.sw.vp9.decoderΓ¥ÖOMX.google.av1.decoderΓ¥Öc2.android.av1.decoderΓ¥ÖOMX.sprd.av1.decoderΓ¥Ö Ya6ls9Pv5oFRV2594wX9ShyNrDhs6A==Γ¥Ö)DarkViperAU's Reddit Recap - October 2023Γ¥Ö134K viewsΓ¥Ö134K viewspΓ¥Ö.https://i.ytimg.com/vi/YlM2TGMaEKQ/default.jpgΓ¥Ö0https://i.ytimg.com/vi/YlM2TGMaEKQ/mqdefault.jpgΓ¥Ö0https://i.ytimg.com/vi/YlM2TGMaEKQ/hqdefault.jpgΓ¥Ö2Ehxjb193YXRjaF9jaGFuZ2VfdmlkZW9fZGlhbG9nIIYDKAE%3DΓ¥Ö

Solution

No response

Additional context

No response

Acknowledgements

LisoUseInAIKyrios commented 6 months ago

The filter needs updating to include horizontal_tile_shelf.eml

LisoUseInAIKyrios commented 6 months ago

Try adding the custom filter ^horizontal_tile_shelf.eml and verify it hides that shelf.

ILoveOpenSourceApplications commented 6 months ago

Try adding the custom filter ^horizontal_tile_shelf.eml and verify it hides that shelf.

It's still showing up.

LisoUseInAIKyrios commented 6 months ago

Then maybe that's not the shelf. Look thru the logs more and see if you can identify which component it is.

LisoUseInAIKyrios commented 6 months ago

The tile might be the individual video in the shelf.

Look just before that log entry for something shelf related, or if any items have Watch it again in the buffer.

ILoveOpenSourceApplications commented 6 months ago

No, it's my bad. I accidentally replaced tile with title in my filter. Let me check again.

ILoveOpenSourceApplications commented 6 months ago

Try adding the custom filter ^horizontal_tile_shelf.eml and verify it hides that shelf.

Yes, this works. I'm not seeing it anymore even after multiple refresh.

ILoveOpenSourceApplications commented 6 months ago

Just now only I noticed, but "Watch it again" is written as Watch it Again in the description of the patch. A small correction is needed there as well.

LisoUseInAIKyrios commented 6 months ago

The casing of Watch it Again might look odd in the settings. The text is the same so users will figure it out.

https://github.com/ReVanced/revanced-integrations/commit/ba308690cf83067d3ddd54622eebcbd14bc15ac8

Try using the latest dev release when it finishes building and confirm it's fixed (with custom filter turned off).

ILoveOpenSourceApplications commented 6 months ago

The casing of Watch it Again might look odd in the settings. The text is the same so users will figure it out.

Might as well correct it in the dev right?

LisoUseInAIKyrios commented 6 months ago

Nevermind, I misunderstood. Yes the patches should be fixed as it has the wrong casing. Fixed on dev

ILoveOpenSourceApplications commented 6 months ago

Looks good. Can't see it anymore.

ILoveOpenSourceApplications commented 6 months ago

https://github.com/ReVanced/revanced-integrations/pull/603

LisoUseInAIKyrios commented 6 months ago

This can be closed now, since the hide horizontal shelves is not released to main yet and is still dev release only.