bug(YouTube/`Hide Shorts components`: Hide like/dislike buttons not working on Shorts ad

ReVanced / revanced-patches

🧩 Patches for ReVanced

https://revanced.app

GNU General Public License v3.0

2.47k stars 286 forks source link

bug(YouTube/`Hide Shorts components`: Hide like/dislike buttons not working on Shorts ad #3056

Closed ILoveOpenSourceApplications closed 5 months ago

ILoveOpenSourceApplications commented 6 months ago

Bug description

Like/dislike buttons are showing in Shorts Ad. Screenshot_2024-04-21-16-24-33-651_app revanced android youtube~2

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

[X] This issue is not a duplicate of an existing bug report.
[X] I have chosen an appropriate title.
[X] All requested information has been provided properly.

LisoUseInAIKyrios commented 6 months ago

Shorts ads use the older non litho player.

Hide like/dislike buttons also does not work for non-ad Shorts if spoofing to an older version.

Both of these might be fixed with the same change.

ILoveOpenSourceApplications commented 6 months ago

Shorts ads use the older non litho player.

Hide like/dislike buttons also does not work for non-ad Shorts if spoofing to an older version.

Both of these might be fixed with the same change.

Ah, I see. The best solution would be to find a way to hide these Shorts Ads but we don't have a way to do that now, right?

n1cKz1 commented 6 months ago

The best solution would be to find a way to hide these Shorts Ads but we don't have a way to do that now, right?

On a semi non-related note, not once I've ran into a Shorts ad, and I watch Shorts relatively often. Are they region based or something?

LisoUseInAIKyrios commented 6 months ago

Turning on 'switch notification' navigation button seems to turn off all video ads.

https://github.com/ReVanced/revanced-patches/issues/219#issuecomment-2000077995