ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.29k stars 264 forks source link

feat(YouTube): Hide 'Listen in Music' button in search #3067

Closed ILoveOpenSourceApplications closed 4 months ago

ILoveOpenSourceApplications commented 5 months ago

Feature description

There's a 'Listen in Music' button in search which shows up below mix playlists. A patch to hide it. Screenshot_20240422_153350_YouTube How it looks if mix playlists is hidden: Screenshot_20240422_155914_YouTube

Motivation

If the user has both ReVanced YouTube and YT Music, then tapping this button redirects the user to play store rather than the YT Music app. Also, if the user has Hide mix playlists on then the button just sits there out of place.

Acknowledgements

ILoveOpenSourceApplications commented 5 months ago

Adding button_banner.eml to custom filters does hide it.

04-22 15:32:22.501 22440 22440 D revanced: LithoFilterPatch: Searching ID: null Path: button_banner.eml|1adb923c2c384f48|CellType|ContainerType|ContainerType|button.eml|e4d01425197b9e68|ContainerType| BufferStrings: quantum_ic_open_in_new_white_36Γ¥ÖListen in MusicΓ¥Ösans-serifΓ¥Ö%com.google.android.apps.youtube.musicΓ¥Övnd.youtube.music://music.youtube.com/channel/UCedvOgsKFzcK3hA5taf3KoQ?syncid=102703968514377483331%7C%7C&referring_app=com.google.android.youtube-o-ytm&ybp=mgYiCiASHhIaUkRBT0FTWnpBQjRONlBTZnNPd3pBaHhZeVEYAQ%253D%253D"Γ¥Ö%com.google.android.apps.youtube.musicΓ¥Ö>com.google.android.apps.youtube.music.activities.MusicActivity"Γ¥Ö%com.google.android.apps.youtube.musicΓ¥Ö%pcampaignid=inline|youtubeads|9416164Γ¥Önmarket://details?id=com.google.android.apps.youtube.music&referrer=pcampaignid%3Dinline%7Cyoutubeads%7C9416164(Γ¥Ö
n1cKz1 commented 5 months ago

Alternatively, changing the package name of the app this button opens to that of ReVanced Music would also be neat

ILoveOpenSourceApplications commented 5 months ago

Alternatively, changing the package name of the app this button opens to that of ReVanced Music would also be neat

Yes, that would be nice as well. I was thinking of that as well but didn't know which one was more feasible and thought that hiding it is much more easier and went with that. Need opinion from @LisoUseInAIKyrios or @oSumAtrIX.

GKid94 commented 5 months ago

Same Screenshot_2024-04-28-12-35-38-409_app revanced android youtube Screenshot_2024-04-28-12-36-56-555_com miui securitycenter

oSumAtrIX commented 4 months ago

Over time, a lot of feature requests have been made, which is why I am closing some according to the contribution guidelines:

Requests can be accepted or rejected at the discretion of maintainers of ReVanced Patches

This feature request has been closed for one or more of the following reasons:

Regardless, anyone who comes across this feature request can PR it. Thanks for the feature request!

ILoveOpenSourceApplications commented 4 months ago
04-22 15:32:22.501 22440 22440 D revanced: LithoFilterPatch: Searching ID: null Path: button_banner.eml|1adb923c2c384f48|CellType|ContainerType|ContainerType|button.eml|e4d01425197b9e68|ContainerType| BufferStrings: quantum_ic_open_in_new_white_36Γ¥ÖListen in MusicΓ¥Ösans-serifΓ¥Ö%com.google.android.apps.youtube.musicΓ¥Övnd.youtube.music://music.youtube.com/channel/UCedvOgsKFzcK3hA5taf3KoQ?syncid=102703968514377483331%7C%7C&referring_app=com.google.android.youtube-o-ytm&ybp=mgYiCiASHhIaUkRBT0FTWnpBQjRONlBTZnNPd3pBaHhZeVEYAQ%253D%253D"Γ¥Ö%com.google.android.apps.youtube.musicΓ¥Ö>com.google.android.apps.youtube.music.activities.MusicActivity"Γ¥Ö%com.google.android.apps.youtube.musicΓ¥Ö%pcampaignid=inline|youtubeads|9416164Γ¥Önmarket://details?id=com.google.android.apps.youtube.music&referrer=pcampaignid%3Dinline%7Cyoutubeads%7C9416164(Γ¥Ö

Instead of the app calling into the stock YT Music app package name, we'll have to change it to ReVanced YT Music package name which will open it in ReVanced YT Music instead of redirecting the user to play store (for those who disabled/uninstalled it).

ILoveOpenSourceApplications commented 4 months ago

I'm just saying my thought here, no idea whether this is possible or not.