search

ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
1.56k stars 184 forks source link

feat(Reddit - Hide banner ads): Constrain to last working version #3156

Closed ascopes closed 2 weeks ago

ascopes commented 2 weeks ago

Until GH-3099 is fixable and addressed, this limits the version of Reddit that can be used to 2024.0.17 which is the last known working version.

ascopes commented 2 weeks ago

Not part of this MR but possibly worth noting that the link to the docs explaining how to structure the commit naming seems to be broken, so the name of this commit is a bit of a stab in the dark on my behalf.

Hopefully this is correct.

ascopes commented 2 weeks ago

If I go for the latter, is it just a case of setting the name attribute directly or do other patches need modifying as well?

Apologise if it is a silly question, somewhat new to how this works!

ericswpark commented 1 week ago

@ascopes why was the head repository deleted? Did another PR supersede this one?

ascopes commented 1 week ago

Ah whoops, I was removing an unused clone for another revanced project and accidentally deleted the wrong one... will reraise with the correct fixes as given above when I get some time as GitHub won't let me restore it from the web UI. Got the repo locally on my PC still so will repush and cherrypick the fix that was committed on top of this.

Need to take some time to understand how things are structured so I get it right.

Sorry about that!

ascopes commented 1 week ago

Reopened at #3192