ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.3k stars 268 forks source link

Patch fail: Premium heading failed #316

Closed iAvoe closed 1 year ago

iAvoe commented 1 year ago

Type

Error while patching

Bug description

Unable to patch YouTube 18.32.36, this problem has been going on for monthes

Log summary:

Premium heading failed: app.revanced.patcher.patch.PatchException: The file /data/user/0/app.revanced.manager.flutter/cache/patcher/tmp-UIEBCY/cache/res/drawable-xxxhdpi/yt_premium_wordmark_header_light.png does not exist in the resources. Therefore, this patch can not succeed.

Steps to reproduce

Executed pstching in Android 10, normal installation on manager 1.9.5, Root permission granted.

Relevant log output

Copying APK
Reading APK
Decoding app manifest
Loading patches
Merging integrations
Deleting existing resource cache directory
Decoding resources
Executing patches
Custom player overlay opacity succeeded
Disable zoom haptics succeeded
Enable debugging succeeded
Enable tablet layout succeeded
Hide cast button succeeded
Premium heading failed: app.revanced.patcher.patch.PatchException: The file /data/user/0/app.revanced.manager.flutter/cache/patcher/tmp-UIEBCY/cache/res/drawable-xxxhdpi/yt_premium_wordmark_header_light.png does not exist in the resources. Therefore, this patch can not succeed.
    at app.revanced.patches.youtube.layout.branding.header.patch.PremiumHeadingPatch.execute(PremiumHeadingPatch.kt:33)
    at app.revanced.patches.youtube.layout.branding.header.patch.PremiumHeadingPatch.execute(PremiumHeadingPatch.kt:14)
    at app.revanced.patcher.Patcher$apply$1.invokeSuspend$executePatch(Patcher.kt:147)
    at app.revanced.patcher.Patcher$apply$1.invokeSuspend(Patcher.kt:170)
    at app.revanced.patcher.Patcher$apply$1.invoke(Unknown Source:8)
    at app.revanced.patcher.Patcher$apply$1.invoke(Unknown Source:4)
    at kotlinx.coroutines.flow.SafeFlow.collectSafely(Builders.kt:61)
    at kotlinx.coroutines.flow.AbstractFlow.collect(Flow.kt:230)
    at app.revanced.manager.flutter.MainActivity$runPatcher$1$2$1.invokeSuspend(MainActivity.kt:214)
    at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
    at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
    at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:280)
    at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:85)
    at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59)
    at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source:1)
    at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38)
    at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source:1)
    at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$13(MainActivity.kt:213)
    at app.revanced.manager.flutter.MainActivity.$r8$lambda$6dokpIuPm1kqn7qLA9JtiVzSCi0(Unknown Source:0)
    at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda3.run(Unknown Source:24)
    at java.lang.Thread.run(Thread.java:919)
Theme succeeded
Compiling modified dex files
Compiling modified resources
An error occurred:
brut.androlib.exceptions.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/data/app/app.revanced.manager.flutter-rd9IFhbQKX0YU2Qya57FMQ==/lib/arm64/libaapt2.so, link, -o, /data/user/0/app.revanced.manager.flutter/cache/patcher/tmp-UIEBCY/cache/aapt_temp_file, --package-id, 127, --min-sdk-version, 26, --target-sdk-version, 33, --version-code, 1539433920, --version-name, 18.32.36, --no-auto-version, --no-version-vectors, --no-version-transitions, --no-resource-deduping, --allow-reserved-package-id, -e, /data/user/0/app.revanced.manager.flutter/cache/APKTOOL8639716712590514217.tmp, -0, arsc, -I, /data/user/0/app.revanced.manager.flutter/cache/patcher/tmp-UIEBCY/cache/1.apk, --manifest, /data/user/0/app.revanced.manager.flutter/cache/patcher/tmp-UIEBCY/cache/AndroidManifest.xml, /data/user/0/app.revanced.manager.flutter/cache/patcher/tmp-UIEBCY/cache/build/resources.zip]
    at brut.androlib.AaptInvoker.invokeAapt2(AaptInvoker.java:246)
    at brut.androlib.AaptInvoker.invokeAapt(AaptInvoker.java:391)
    at app.revanced.patcher.data.ResourceContext.get(ResourceContext.kt:126)
    at app.revanced.patcher.Patcher.get(Patcher.kt:232)
    at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$13(MainActivity.kt:244)
    at app.revanced.manager.flutter.MainActivity.$r8$lambda$6dokpIuPm1kqn7qLA9JtiVzSCi0(Unknown Source:0)
    at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda3.run(Unknown Source:24)
    at java.lang.Thread.run(Thread.java:919)
Caused by: brut.common.BrutException: could not exec (exit code = 1): [/data/app/app.revanced.manager.flutter-rd9IFhbQKX0YU2Qya57FMQ==/lib/arm64/libaapt2.so, link, -o, /data/user/0/app.revanced.manager.flutter/cache/patcher/tmp-UIEBCY/cache/aapt_temp_file, --package-id, 127, --min-sdk-version, 26, --target-sdk-version, 33, --version-code, 1539433920, --version-name, 18.32.36, --no-auto-version, --no-version-vectors, --no-version-transitions, --no-resource-deduping, --allow-reserved-package-id, -e, /data/user/0/app.revanced.manager.flutter/cache/APKTOOL8639716712590514217.tmp, -0, arsc, -I, /data/user/0/app.revanced.manager.flutter/cache/patcher/tmp-UIEBCY/cache/1.apk, --manifest, /data/user/0/app.revanced.manager.flutter/cache/patcher/tmp-UIEBCY/cache/AndroidManifest.xml, /data/user/0/app.revanced.manager.flutter/cache/patcher/tmp-UIEBCY/cache/build/resources.zip]
    at brut.util.OS.exec(OS.java:104)
    at brut.androlib.AaptInvoker.invokeAapt2(AaptInvoker.java:242)
    ... 7 more

Screenshots or videos

No response

Solution

No response

Additional context

I am not sure but it's likely the 'Premuim' text replacing 'YouTube' after you pay for YouTibe premium. I don't necessarily need that premium heading displaying, if that's the source of problems

Acknowledgements

oSumAtrIX commented 1 year ago

You are patching a split APK file that does not have the resource.

LisoUseInAIKyrios commented 1 year ago

And 18.32.36 is not a supported version

oSumAtrIX commented 1 year ago

The patch is not constrained to any version