ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.41k stars 278 forks source link

feat(YouTube - Hide description components): Hide 'Shorts remixing this video' section #3184

Open ILoveOpenSourceApplications opened 5 months ago

ILoveOpenSourceApplications commented 5 months ago

Feature description

People can make Shorts out of other peoples video and these Shorts will show up in the description of those original videos. A patch which can hide this.

Screenshot_2024-05-17-13-48-50-935_app revanced android youtube~2

Logcat:

05-17 13:42:00.375 16572 16572 D revanced: LithoFilterPatch: Searching ID: null Path: shorts_shelf.eml|e1ae000441f839e3|CellType|shelf_header.eml|e3884aa9158f226e| BufferStrings: shorts_shelf.shelf_headerΓ¥Ömodern_type_shelf_header_content.eml|45ab38be02f0a686Γ¥Ö
05-17 13:42:00.377 16572 16572 D revanced: LithoFilterPatch: Searching ID: null Path: shorts_shelf.eml|e1ae000441f839e3|CellType|shelf_header.eml|e3884aa9158f226e|modern_type_shelf_header_content.eml|45ab38be02f0a686|ContainerType| BufferStrings: shorts_shelf.shelf_headerΓ¥Öbutton.eml|8667ba4de0f5ee49Γ¥Ö1 ShortΓ¥Ösans-serifΓ¥ÖShorts remixing this videoΓ¥Ösans-serifΓ¥ÖShorts remixing this video, 1 ShortΓ¥Öeml.shelf_headerΓ¥Ö
05-17 13:42:00.381 16572 16572 D revanced: LithoFilterPatch: Searching ID: null Path: shorts_shelf.eml|e1ae000441f839e3|CellType|shelf_header.eml|e3884aa9158f226e|modern_type_shelf_header_content.eml|45ab38be02f0a686|ContainerType|ContainerType|ContainerType|button.eml|8667ba4de0f5ee49|ContainerType| BufferStrings: View allΓ¥Ösans-serifΓ¥ÖView allΓ¥ÖFEsfv_audio_pivotΓ¥ÖF8gUvChwSGgoLbnl4Y08ydmRjQ2cSC255eGNPMnZkY0NnMAI6DQoLWkdjX3dFRGRDVjg%3DΓ¥

Motivation

This being the only section left out being hidden in the description section, it's Shorts remixed out of the original video, meaning you've already seen the content and it's Shorts.

Acknowledgements

johnconner122 commented 5 months ago

It should already be filtered by hide shorts toggle.

ILoveOpenSourceApplications commented 5 months ago

Yes, Hide Shorts in home feed does hide it, but these Shorts are part of the description. So a separate switch dedicated to hiding it in description would make sense. Given, there are users who watch Shorts, but never watch a video just to watch a Short remixed from a specific video. Also, those who don't use hide shorts shelf patch but wants a clean description would be appreciative (including me) for a separate switch in description.

ILoveOpenSourceApplications commented 4 months ago

Will adding shorts_shelf.eml in description filters affect description only or will it hide shorts from every other place as well?

johnconner122 commented 4 months ago

Will adding shorts_shelf.eml in description filters affect description only or will it hide shorts from every other place as well?

It will probably remove shorts from most places. It needs player type check for description.

LisoUseInAIKyrios commented 4 months ago

the Shorts filter already checks the player type, that's why the hide Shorts in home feed applies to the player as well.

Unless there is something non localized in the buffer that indicates it's the remix shelf, there may not be a simple way to selectively hide this.