ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
1.89k stars 217 forks source link

feat: fill to zoom #3186

Closed es419 closed 1 month ago

es419 commented 1 month ago

Feature description

Since v18..30 and up fill to zoom isnt working properly. Pls add and fix the function that does that. Fill to zoom feature is missing for a long time

Motivation

This feature is basic necessary youtube feature. People want to watch videos on size that fit to their phone size and not crop. Beside, this feature was broken for a long time and a lot of people wants it. Also, you need to fix just one line of code... this shouldnt suppose to be hard.

use the gesture to pinch the screen is very unconvenient as we need to do it every time we restart the app. this is make the videos watch very unfun and unenjoying.

Acknowledgements

LisoUseInAIKyrios commented 1 month ago

You already created an issue for this

https://github.com/ReVanced/revanced-patches/issues/3185

Also, you need to fix just one line of code... this shouldnt suppose to be hard.

You are invited to find and share this one line fix, if it is so simple as you say.

es419 commented 1 month ago

i wish. i just dont know how to read assembly/smali code and find the function that responsible for this feature and fix the code. thats why im asking from you. im sure you can do a great job as you always do.

oSumAtrIX commented 1 month ago

Then it's not a simple one liner. The feature already exists Screenshot_20240517-122320

es419 commented 1 month ago

but the code is broken. maybe the feature exist but it isnt working. the code is broken.

LisoUseInAIKyrios commented 1 month ago

This is likely a bug in YT itself.

The only way this can be a ReVanced issue, is if including a specific patch during patching causes the problem (and excluding that patch fixes the issue). If you can identify a ReVanced patch that, if excluded, the problem is fixed, then create a new bug issue with the details.

Otherwise, go ask YT to fix the issue because it's not a ReVanced problem.

es419 commented 1 month ago

i did ask from google they dont answer. also, maybe you can write a new patch that just does the same thing. maybe i opened an revanced issue but its under feature request. i dont know how simple is this but im sure you can do it. if i would know smali i would do it myself.

oSumAtrIX commented 1 month ago

Send a recording of the following:

  1. Open the unpatched YouTube app
  2. Enable that toggle in the settings
  3. Show that it doesn't autofill by default
LisoUseInAIKyrios commented 1 month ago

Re-read what is written. It's not a ReVanced issue. Fixing YT bugs with patches is unrealistic.

es419 commented 1 month ago

you agree its feature request?

es419 commented 1 month ago

can i send it in private?

es419 commented 1 month ago

?