ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
1.96k stars 226 forks source link

bug: replace download button has a hidden bug by itself #3221

Closed Frontline11 closed 1 month ago

Frontline11 commented 1 month ago

Bug description

the replace download button function has a problem with a bug, we activate it to replace it does not appear Where is it share save thank you it does not appear the fixed download button , Patch is updated to the latest version

Error logs

No response

Solution

review the patch for this problem fix the error

Additional context

No response

Acknowledgements

LisoUseInAIKyrios commented 1 month ago

Not sure what you're talking of. Post a photo or video showing the issue.

The external downloader opens when using the download action button (button in same group as like/dislike), and also works when using the download flyout menu for videos in home/search. It does not change anything with the share menu.

sudoshindo commented 1 month ago

https://github.com/ReVanced/revanced-patches/assets/97193233/f0cbbcca-a7b0-4845-be9c-f2969d53ac93

I have a strong hunch that this is what they mean. (4.8.3)

Please look very closely at the action buttons in the screen recording above.

Action buttons > Hide download is NOT ENABLED.

I also tried constantly switching all of the settings under External downloads. Whether I flip them on or off, the native download button doesn't become visible again.

oSumAtrIX commented 1 month ago

Open a new issue and identify which patch causes the issue by excluding them when patching the app. You can use binary search

raniesantos commented 1 month ago

I had this issue in 4.8.1 but I was able to fix it by messing with External Download settings.

I'm on 4.8.3 now and I can't find any workaround to unhide it anymore.