bug: Patching against normal MicroG, app crashes instantly

perz1val-git commented 4 months ago

Bug description

I have a device with LineageOS 21 (android 14) with microg (also called GMS Core) - no google services at all. From my understanding ReVanced GMS core has just a different package name and "some modifications" to allow it running without being installed as a system app. ReVanced manager allows changing package name for GMS Core patch.

I tried with YT Music.

I changed it to: Screenshot_20240528-105515_ReVanced Manager

Which should be the same as my microg package "com.google.android.gms"

The app crashed/closed just after being launched.

There is no indicator that it shouldn't be working, so I consider this a bug. The app patched fine and then crashed, so I guess this patches repo is the right place.

I would like to get it working or at least a clear disclaimer/explanation in ReVanced's GMS Core fork readme (seems like the best place to me) that it cannot be done (would like to know why too).

In case it can be fixed, it would be great if the normal microg was added to the select list in patch settings.

I am a dev, not an android dev, but I may give some help if you want to actually get it working. I also have a second degoogled phone that may be used for experimentation.

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

[X] This issue is not a duplicate of an existing bug report.
[X] I have chosen an appropriate title.
[X] All requested information has been provided properly.

oSumAtrIX commented 4 months ago

GmsCore whitelists the original signature of the app. Not a ReVanced issue

Tun2Sucks commented 3 months ago

try "com.mgoogle"

weskerty commented 3 months ago

What to do if you already have an official microG? or is it mandatory to use the modified microg?

oSumAtrIX commented 3 months ago

For support, move to one of our links at https://revanced.app.

ParzivalWolfram commented 3 weeks ago

What to do if you already have an official microG? or is it mandatory to use the modified microg?

It appears that installing the stock app, then installing the patched app with the "mount" option, works. Background play, however, doesn't work in that configuration.

For support, move to one of our links at https://revanced.app.

This is a repo under the GitHub org linked on that page, yes. If the issue is here, the user has already done that.

ReVanced / revanced-patches