ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.01k stars 235 forks source link

bug(YouTube - Hide ads): Some home feed ads are not hidden #3398

Closed LisoUseInAIKyrios closed 6 days ago

LisoUseInAIKyrios commented 2 weeks ago

Bug description

A new kind of ad is sometimes showing up in the home feed, but it's not common.

It appears with the litho component full_width_square_image_button_group_layout.eml

The buffer also has an analytic ad url that can be used, if the litho path is also used by some other non ad content.

Solution

Add two custom filters: full_width_square_image_button_group_layout.eml landscape_image_button_group_layout.eml

Acknowledgements

ILoveOpenSourceApplications commented 2 weeks ago

Is the ad, the same as mentioned in this https://github.com/inotia00/ReVanced_Extended/issues/2210?

LisoUseInAIKyrios commented 2 weeks ago

That roughly looks the same, yes.

LisoUseInAIKyrios commented 2 weeks ago

There is at least two different new ad components. Filtering both seems to fix it:

full_width_square_image_button_group_layout.eml landscape_image_button_group_layout.eml

oSumAtrIX commented 2 weeks ago

I think "button_group_layout.eml" should work fine for both

ILoveOpenSourceApplications commented 1 week ago
final var buttonedAd = new StringFilterGroup(
                Settings.HIDE_BUTTONED_ADS,
                "_buttoned_layout",
                "full_width_square_image_layout",
                "_ad_with",
                "text_image_button_group_layout",
                "video_display_button_group_layout",
                "landscape_image_wide_button_layout",
                "video_display_carousel_button_group_layout"

I think "button_group_layout.eml" should work fine for both

With this change, the filter components can be reduced to:

final var buttonedAd = new StringFilterGroup(
                Settings.HIDE_BUTTONED_ADS,
                "_buttoned_layout",
                "full_width_square_image_layout",
                "_ad_with",
                "landscape_image_wide_button_layout",
                "_button_group_layout"