search

ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.06k stars 238 forks source link

bug: Twitter / X Open Links Fails #3431

Open illmatic73 opened 3 weeks ago

illmatic73 commented 3 weeks ago

Bug description

  1. Download latest Twitter / X APK (10.49.0)
  2. Select APK from storage to patch in Revanced Manager
  3. Select default patches and "Open links with app chooser"
  4. Rest of patches apply but "Open Links with app chooser" fails

Error logs

- Device Info
ReVanced Manager: 1.20.1
Model: SM-G981U
Android version: 13
Supported architectures: arm64-v8a, armeabi-v7a, armeabi
Root permissions: No

- Patch Info
App: com.twitter.android v10.49.0-release.0 (Suggested: Any)
Patches version: v4.11.0
Patches added: Open links with app chooser
Patches removed: None
Default patch options changed: None

- Settings
Allow changing patch selection: true
Version compatibility check: true
Show universal patches: false
Patches source: revanced/revanced-patches
Integration source: revanced/revanced-integrations

- Logs
Reading APK
Decoding app manifest
Loading patches
Merging integrations
Deleting existing temporary files directory
Decoding resources
Executing patches
Applied 5 patches
Open links with app chooser failed: app.revanced.patcher.patch.PatchException: Failed to resolve OpenLinkFingerprint
    at app.revanced.util.BytecodeUtilsKt.getException(BytecodeUtils.kt:27)
    at app.revanced.patches.twitter.misc.links.OpenLinksWithAppChooserPatch.execute(OpenLinksWithAppChooserPatch.kt:33)
    at app.revanced.patches.twitter.misc.links.OpenLinksWithAppChooserPatch.execute(OpenLinksWithAppChooserPatch.kt:11)
    at app.revanced.patcher.Patcher$apply$1.invokeSuspend$executePatch(Unknown Source:190)
    at app.revanced.patcher.Patcher$apply$1.invokeSuspend(Unknown Source:292)
    at app.revanced.patcher.Patcher$apply$1.invoke(SourceFile:0)
    at app.revanced.patcher.Patcher$apply$1.invoke(SourceFile:0)
    at kotlinx.coroutines.flow.SafeFlow.collectSafely(Unknown Source:2)
    at kotlinx.coroutines.flow.AbstractFlow.collect(Unknown Source:71)
    at app.revanced.manager.flutter.MainActivity$runPatcher$1$patcherResult$1$2.invokeSuspend(Unknown Source:76)
    at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(Unknown Source:11)
    at kotlinx.coroutines.DispatchedTask.run(Unknown Source:93)
    at kotlinx.coroutines.EventLoopImplBase.processNextEvent(Unknown Source:46)
    at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Unknown Source:23)
    at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Unknown Source:73)
    at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source:0)
    at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Unknown Source:6)
    at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source:0)
    at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$34(Unknown Source:470)
    at app.revanced.manager.flutter.MainActivity.$r8$lambda$hTJfH-rv2j-9Y91G5H_L5jFDN6U(SourceFile:0)
    at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda5.run(SourceFile:0)
    at java.lang.Thread.run(Thread.java:1012)
Compiling patched dex files
Compiled 12 dex files
Compiling modified resources
Aligning APK
Signing APK
Patched APK

Solution

No response

Additional context

No response

Acknowledgements

cyberboh commented 3 weeks ago

Similar to my https://github.com/ReVanced/revanced-patches/issues/2846 The patch actually not reliable

fessmm commented 3 weeks ago

Can confirm, same bug happens for me too

Edit:

here the logs:

- Device Info
ReVanced Manager: 1.20.1
Model: SM-S928B
Android version: 14
Supported architectures: arm64-v8a
Root permissions: No

- Patch Info
App: [com.twitter.android](https://com.twitter.android/) v10.49.0-release.0 (Suggested: Any)
Patches version: v4.11.0
Patches added: Open links with app chooser
Patches removed: None
Default patch options changed: None

- Settings
Allow changing patch selection: true
Version compatibility check: true
Show universal patches: false
Patches source: revanced/revanced-patches
Integration source: revanced/revanced-integrations

- Logs
Reading APK
Decoding app manifest
Loading patches
Merging integrations
Deleting existing temporary files directory
Decoding resources
Executing patches
Applied 5 patches
Open links with app chooser failed: app.revanced.patcher.patch.PatchException: Failed to resolve OpenLinkFingerprint
 at app.revanced.util.BytecodeUtilsKt.getException(BytecodeUtils.kt:27)
 at app.revanced.patches.twitter.misc.links.OpenLinksWithAppChooserPatch.execute(OpenLinksWithAppChooserPatch.kt:33)
 at app.revanced.patches.twitter.misc.links.OpenLinksWithAppChooserPatch.execute(OpenLinksWithAppChooserPatch.kt:11)
 at app.revanced.patcher.Patcher$apply$1.invokeSuspend$executePatch(Unknown Source:190)
 at app.revanced.patcher.Patcher$apply$1.invokeSuspend(Unknown Source:292)
 at app.revanced.patcher.Patcher$apply$1.invoke(SourceFile:0)
 at app.revanced.patcher.Patcher$apply$1.invoke(SourceFile:0)
 at kotlinx.coroutines.flow.SafeFlow.collectSafely(Unknown Source:2)
 at kotlinx.coroutines.flow.AbstractFlow.collect(Unknown Source:71)
 at app.revanced.manager.flutter.MainActivity$runPatcher$1$patcherResult$1$2.invokeSuspend(Unknown Source:76)
 at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(Unknown Source:11)
 at [kotlinx.coroutines.DispatchedTask.run](https://kotlinx.coroutines.dispatchedtask.run/)(Unknown Source:93)
 at kotlinx.coroutines.EventLoopImplBase.processNextEvent(Unknown Source:46)
 at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Unknown Source:23)
 at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Unknown Source:73)
 at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source:0)
 at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Unknown Source:6)
 at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source:0)
 at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$34(Unknown Source:470)
 at app.revanced.manager.flutter.MainActivity.$r8$lambda$hTJfH-rv2j-9Y91G5H_L5jFDN6U(SourceFile:0)
 at app.revanced.manager.flutter.MainActivity$$[ExternalSyntheticLambda5.run](https://externalsyntheticlambda5.run/)(SourceFile:0)
 at [java.lang.Thread.run](https://java.lang.thread.run/)(thread.java:1012)
Compiling patched dex files
Compiled 12 dex files
Compiling modified resources
Aligning APK
Signing APK
Patched APK