search

ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.49k stars 290 forks source link

bug: (Reddit) "Hide Ads" crashes the app #359

Closed snappyapple632 closed 1 year ago

snappyapple632 commented 1 year ago

Type

Error at runtime

Bug description

When the Reddit app is patched with the "Hide Ads" patch, the app crashes at startup.

Steps to reproduce

  1. Select the "Hide Ads" patch.
  2. Patch the app.
  3. Open the app.
  4. App crashes at startup.

Relevant log output

---- Sep 5, 2023 11:27:22 AM ----

09-05 11:27:30.292  1156  3106 I ActivityTaskManager: START u0 {act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] flg=0x10200000 cmp=com.reddit.frontpage/launcher.vaporwave bnds=[585,1720][855,2125]} from uid 10143 pid 4622

09-05 11:27:30.310  1156  1491 I OpMotorManagerService: notifyActivityChanged: mBackgroudPkg = net.oneplus.launcher mFocusPkg = com.reddit.frontpage mIsSplitMode = true mBackActivity = net.oneplus.launcher mFocusActivity = launcher.vaporwave

09-05 11:27:30.334   986  1033 I /vendor/bin/hw/vendor.qti.hardware.servicetracker@1.0-service: bindService is called for service : com.reddit.frontpage/com.google.android.datatransport.runtime.scheduling.jobscheduling.JobInfoSchedulerService and for client system

09-05 11:27:30.334   986  1033 I /vendor/bin/hw/vendor.qti.hardware.servicetracker@1.0-service: total connections for service : com.reddit.frontpage/com.google.android.datatransport.runtime.scheduling.jobscheduling.JobInfoSchedulerServiceare :1

09-05 11:27:30.335   986  1033 I /vendor/bin/hw/vendor.qti.hardware.servicetracker@1.0-service: bindService is called for service : com.reddit.frontpage/com.google.android.datatransport.runtime.scheduling.jobscheduling.JobInfoSchedulerService and for client system

09-05 11:27:30.335   986  1033 I /vendor/bin/hw/vendor.qti.hardware.servicetracker@1.0-service: total connections for service : com.reddit.frontpage/com.google.android.datatransport.runtime.scheduling.jobscheduling.JobInfoSchedulerServiceare :1

09-05 11:27:30.340  1156  1315 I ActivityManager: Start proc 11773:com.reddit.frontpage/u0a372 for activity {com.reddit.frontpage/launcher.vaporwave}

09-05 11:27:30.428  1156  7199 E ScreenModeService: getAppToken AppWindowToken{3c6d075 token=Token{5d04bac ActivityRecord{468655f u0 com.reddit.frontpage/launcher.vaporwave t6585}}}

09-05 11:27:30.428  1156  7199 E ScreenModeService: setRefreshRate token AppWindowToken{3c6d075 token=Token{5d04bac ActivityRecord{468655f u0 com.reddit.frontpage/launcher.vaporwave t6585}}} rate 0

09-05 11:27:30.437  1156  1234 I RemoteAnimationController: token=AppWindowToken{3c6d075 token=Token{5d04bac ActivityRecord{468655f u0 com.reddit.frontpage/launcher.vaporwave t6585}}}

09-05 11:27:30.437  1156  1234 I RemoteAnimationController:   leash=Surface(name=Surface(name=AppWindowToken{3c6d075 token=Token{5d04bac ActivityRecord{468655f u0 com.reddit.frontpage/launcher.vaporwave t6585}}})/@0xba12f5e - animation-leash)/@0xc3ff3f

09-05 11:27:30.445   986  1033 I /vendor/bin/hw/vendor.qti.hardware.servicetracker@1.0-service: startService() is called for servicecom.reddit.frontpage/com.google.android.datatransport.runtime.scheduling.jobscheduling.JobInfoSchedulerService

09-05 11:27:30.452 11773 11773 E eddit.frontpag: Dex checksum does not match for dex: /data/app/com.reddit.frontpage-cOkjRCdb8L4gxEwPzpGhFg==/base.apk.Expected: 928674620, actual: 4133926101

09-05 11:27:30.456  1156  1491 I OpMotorManagerService: notifyActivityChanged: mBackgroudPkg = com.reddit.frontpage mFocusPkg = scd.lcex mIsSplitMode = true mBackActivity = launcher.vaporwave mFocusActivity = scd.lcex.ActivityMain

09-05 11:27:33.154 11773 11773 I chatty  : uid=10372(com.reddit.frontpage) identical 1 line

09-05 11:27:33.764 11773 11832 I FA      :   adb shell setprop debug.firebase.analytics.app com.reddit.frontpage

09-05 11:27:33.791   986  1033 I /vendor/bin/hw/vendor.qti.hardware.servicetracker@1.0-service: bindService is called for service : com.google.android.gms/.measurement.service.MeasurementBrokerService and for client com.reddit.frontpage

09-05 11:27:33.791   986  1033 I /vendor/bin/hw/vendor.qti.hardware.servicetracker@1.0-service: total connections for client : com.reddit.frontpageare :1

09-05 11:27:33.818   986  1033 I /vendor/bin/hw/vendor.qti.hardware.servicetracker@1.0-service: bindService is called for service : com.google.android.gms/.ads.identifier.service.AdvertisingIdService and for client com.reddit.frontpage

09-05 11:27:33.818   986  1033 I /vendor/bin/hw/vendor.qti.hardware.servicetracker@1.0-service: total connections for client : com.reddit.frontpageare :2

09-05 11:27:33.874 11773 11850 E Perf    : Fail to get file list com.reddit.frontpage

09-05 11:27:34.267   986  1033 I /vendor/bin/hw/vendor.qti.hardware.servicetracker@1.0-service: bindService is called for service : com.google.android.gms/.ads.identifier.service.AdvertisingIdService and for client com.reddit.frontpage

09-05 11:27:34.268   986  1033 I /vendor/bin/hw/vendor.qti.hardware.servicetracker@1.0-service: total connections for client : com.reddit.frontpageare :2

09-05 11:27:34.458   986  1033 I /vendor/bin/hw/vendor.qti.hardware.servicetracker@1.0-service: bindService is called for service : com.android.vending/com.google.android.finsky.externalreferrer.GetInstallReferrerService and for client com.reddit.frontpage

09-05 11:27:34.458   986  1033 I /vendor/bin/hw/vendor.qti.hardware.servicetracker@1.0-service: total connections for client : com.reddit.frontpageare :3

09-05 11:27:34.478   986  1033 I /vendor/bin/hw/vendor.qti.hardware.servicetracker@1.0-service: bindService is called for service : com.reddit.frontpage/androidx.work.impl.background.systemjob.SystemJobService and for client system

09-05 11:27:34.478   986  1033 I /vendor/bin/hw/vendor.qti.hardware.servicetracker@1.0-service: total connections for service : com.reddit.frontpage/androidx.work.impl.background.systemjob.SystemJobServiceare :1

09-05 11:27:34.485   986  1033 I /vendor/bin/hw/vendor.qti.hardware.servicetracker@1.0-service: startService() is called for servicecom.reddit.frontpage/androidx.work.impl.background.systemjob.SystemJobService

09-05 11:27:34.510   986  1033 I /vendor/bin/hw/vendor.qti.hardware.servicetracker@1.0-service: bindService is called for service : com.reddit.frontpage/androidx.work.impl.background.systemjob.SystemJobService and for client system

09-05 11:27:34.510   986  1033 I /vendor/bin/hw/vendor.qti.hardware.servicetracker@1.0-service: total connections for service : com.reddit.frontpage/androidx.work.impl.background.systemjob.SystemJobServiceare :1

09-05 11:27:34.519   986  1033 I /vendor/bin/hw/vendor.qti.hardware.servicetracker@1.0-service: bindService is called for service : com.reddit.frontpage/androidx.work.impl.background.systemjob.SystemJobService and for client system

09-05 11:27:34.519   986  1033 I /vendor/bin/hw/vendor.qti.hardware.servicetracker@1.0-service: total connections for service : com.reddit.frontpage/androidx.work.impl.background.systemjob.SystemJobServiceare :1

09-05 11:27:34.531   986  1033 I /vendor/bin/hw/vendor.qti.hardware.servicetracker@1.0-service: bindService is called for service : com.reddit.frontpage/androidx.work.impl.background.systemjob.SystemJobService and for client system

09-05 11:27:34.531   986  1033 I /vendor/bin/hw/vendor.qti.hardware.servicetracker@1.0-service: total connections for service : com.reddit.frontpage/androidx.work.impl.background.systemjob.SystemJobServiceare :1

09-05 11:27:34.802 11773 11773 E AndroidRuntime: Process: com.reddit.frontpage, PID: 11773

09-05 11:27:34.802 11773 11773 E AndroidRuntime: java.lang.RuntimeException: Unable to start activity ComponentInfo{com.reddit.frontpage/com.reddit.launch.main.MainActivity}: android.view.InflateException: Binary XML file line ReVanced/revanced-patches#10 in com.reddit.frontpage:layout/activity_main: Binary XML file line ReVanced/revanced-patches#13: You must supply a layout_height attribute.

09-05 11:27:34.802 11773 11773 E AndroidRuntime: Caused by: android.view.InflateException: Binary XML file line ReVanced/revanced-patches#10 in com.reddit.frontpage:layout/activity_main: Binary XML file line ReVanced/revanced-patches#13: You must supply a layout_height attribute.

09-05 11:27:34.802 11773 11773 E AndroidRuntime:    at com.reddit.themes.RedditThemedActivity.setContentView(RedditThemedActivity.kt:6)

09-05 11:27:34.802 11773 11773 E AndroidRuntime:    at com.reddit.legacyactivity.BaseActivity.onCreate(BaseActivity.kt:104)

09-05 11:27:34.802 11773 11773 E AndroidRuntime:    at com.reddit.launch.main.MainActivity.onCreate(MainActivity.kt:53)

09-05 11:27:36.917  1156  4341 W ActivityTaskManager:   Force finishing activi

Screenshots or videos

No response

Solution

No response

Additional context

No response

Acknowledgements

oSumAtrIX commented 1 year ago

The logs indicate that you are patching a split APK which is unsupported.