search

ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.54k stars 294 forks source link

feat(YouTube): Prevent mix playlists from starting when playing music from feeds #3597

Open KobeW50 opened 2 months ago

KobeW50 commented 2 months ago

Feature description

Context

When playing music or music videos (from anywhere except channel profiles), a mix playlist will be started automatically. I am not sure if this is a/b testing or if it has been rolled out to everyone.

https://github.com/user-attachments/assets/7b6d1600-090f-407d-9720-daf8fd5407b2

Feature

Prevent this mix playlist from starting.

Motivation

In most cases, users just want to watch one or two music videos instead of using YouTube as their music streaming platform and therefore are not interested in the autoplay only playing music instead of regular content. This is similar to why many users hide mixes in the feed.

Additionally, the panel bar at the bottom of the related videos makes it difficult to see videos below the player.

Acknowledgements

LisoUseInAIKyrios commented 2 months ago

I tried and don't see this. Must be an a/b test.

Feature request needs a title.

KobeW50 commented 2 months ago

If it helps, here are logs I captured:

logcat.txt (redacted)

This screen recording shows what I did:

https://github.com/user-attachments/assets/872d6352-5cbf-4e74-9a35-011bec24f1ec

LisoUseInAIKyrios commented 2 months ago

Logs won't show anything unique if it's an a/b feature flag.

By the way, proto buffer logging includes device IP and other info some might find sensitive. If sharing with it enabled, the log should always manually review and edited or only share specific log lines (unless someone just doesn't care).

Should probably add a confirmation dialog if the user wants to enable buffer logging. Can also add a bit of text explaining the feature is useful for creating new custom filters. Or maybe just add an brief explanation of this to the summary enabled text and have no dialog confirmation.

oSumAtrIX commented 2 months ago

A filter could be added for the floating playlist card at the bottom, autoplay disabled

koeliga commented 2 months ago

Do you have autoplay off? When you have autoplay on and watch a music video it automatically forces the mix, so try it again with autoplay off.