ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.48k stars 287 forks source link

bug: Can't build Reddit Sync Patched APK in Revanced Manager #3698

Closed soda3x closed 1 month ago

soda3x commented 1 month ago

Bug description

Building Reddit Sync with Patches results in a patch exception that seems to be related to Imgur.

Seems to fail on the "Spoof client" patch.

Error logs

- Device Info
ReVanced Manager: 1.22.0
Model: Pixel 7 Pro
Android version: 14
Supported architectures: arm64-v8a
Root permissions: No

- Patch Info
App: com.laurencedawson.reddit_sync vv23.06.30-13:39 (Suggested: v23.06.30-13:39)
Patches version: v4.15.0
Patches added: Use /user/ endpoint
Patches removed: None
Default patch options changed: Spoof client [OAuth client ID: REDACTED]

- Settings
Allow changing patch selection: true
Version compatibility check: true
Show universal patches: false
Patches source: revanced/revanced-patches
Integration source: revanced/revanced-integrations

- Logs
Reading APK
Decoding app manifest
Loading patches
Merging integrations
Executing patches
Applied 3 patches
Spoof client failed: app.revanced.patcher.patch.PatchException: Failed to resolve GetUserAgentFingerprint
    at app.revanced.util.BytecodeUtilsKt.getException(BytecodeUtils.kt:27)
    at app.revanced.patches.reddit.customclients.BaseSpoofClientPatch.execute$executePatch(BaseSpoofClientPatch.kt:44)
    at app.revanced.patches.reddit.customclients.BaseSpoofClientPatch.execute(BaseSpoofClientPatch.kt:47)
    at app.revanced.patches.reddit.customclients.BaseSpoofClientPatch.execute(BaseSpoofClientPatch.kt:11)
    at app.revanced.patcher.Patcher$apply$1.invokeSuspend$executePatch(Unknown Source:190)
    at app.revanced.patcher.Patcher$apply$1.invokeSuspend(Unknown Source:282)
    at app.revanced.patcher.Patcher$apply$1.invoke(SourceFile:0)
    at app.revanced.patcher.Patcher$apply$1.invoke(SourceFile:0)
    at kotlinx.coroutines.flow.SafeFlow.collectSafely(Unknown Source:2)
    at kotlinx.coroutines.flow.AbstractFlow.collect(Unknown Source:71)
    at app.revanced.manager.flutter.MainActivity$runPatcher$1$patcherResult$1$2.invokeSuspend(Unknown Source:76)
    at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(Unknown Source:11)
    at kotlinx.coroutines.DispatchedTask.run(Unknown Source:98)
    at kotlinx.coroutines.EventLoopImplBase.processNextEvent(Unknown Source:23)
    at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Unknown Source:26)
    at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Unknown Source:73)
    at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source:0)
    at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Unknown Source:6)
    at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source:0)
    at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$35(Unknown Source:464)
    at app.revanced.manager.flutter.MainActivity.$r8$lambda$t9VOe3aFJZkCMY59Ya4Pcinu-pA(SourceFile:0)
    at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda6.run(SourceFile:0)
    at java.lang.Thread.run(Thread.java:1012)
Use /user/ endpoint failed: app.revanced.patcher.patch.PatchException: Failed to resolve OAuthFriendRequestFingerprint
    at app.revanced.util.BytecodeUtilsKt.getException(BytecodeUtils.kt:27)
    at app.revanced.util.BytecodeUtilsKt.resultOrThrow(BytecodeUtils.kt:19)
    at app.revanced.patches.reddit.customclients.syncforreddit.fix.user.UseUserEndpointPatch.execute(UseUserEndpointPatch.kt:48)
    at app.revanced.patches.reddit.customclients.syncforreddit.fix.user.UseUserEndpointPatch.execute(UseUserEndpointPatch.kt:19)
    at app.revanced.patcher.Patcher$apply$1.invokeSuspend$executePatch(Unknown Source:190)
    at app.revanced.patcher.Patcher$apply$1.invokeSuspend(Unknown Source:282)
    at app.revanced.patcher.Patcher$apply$1.invoke(SourceFile:0)
    at app.revanced.patcher.Patcher$apply$1.invoke(SourceFile:0)
    at kotlinx.coroutines.flow.SafeFlow.collectSafely(Unknown Source:2)
    at kotlinx.coroutines.flow.AbstractFlow.collect(Unknown Source:71)
    at app.revanced.manager.flutter.MainActivity$runPatcher$1$patcherResult$1$2.invokeSuspend(Unknown Source:76)
    at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(Unknown Source:11)
    at kotlinx.coroutines.DispatchedTask.run(Unknown Source:98)
    at kotlinx.coroutines.EventLoopImplBase.processNextEvent(Unknown Source:23)
    at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Unknown Source:26)
    at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Unknown Source:73)
    at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source:0)
    at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Unknown Source:6)
    at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source:0)
    at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$35(Unknown Source:464)
    at app.revanced.manager.flutter.MainActivity.$r8$lambda$t9VOe3aFJZkCMY59Ya4Pcinu-pA(SourceFile:0)
    at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda6.run(SourceFile:0)
    at java.lang.Thread.run(Thread.java:1012)
Compiling patched dex files
Compiled 4 dex files
Aligning APK
Signing APK
Patched APK

Solution

No response

Additional context

No response

Acknowledgements

soda3x commented 1 month ago

Nevermind, seemed to be related to patching the installed app. Tried again with a downloaded apk and it worked fine.