bug(YouTube - Playback speed): Custom playback speeds do not work with the new speed menu

LisoUseInAIKyrios commented 3 hours ago

Bug description

19.34+ has an a/b test for a new playback speed menu.

It has 0.05x increments similar to the default ReVanced custom speeds of 0.90/0.95/1.05/1.1, but can also adjust by 0.05 increments from any present.

The max speed is still limited to 2.0.

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

[x] I have checked all open and closed bug reports and this is not a duplicate.
[x] I have chosen an appropriate title.
[x] All requested information has been provided properly.

oSumAtrIX commented 3 hours ago

I think this is fine to remove the patch. Anything above 2x is hardly useful and the precise speed slider is precise enough. On a related note, the speed entries are sent with the /player response from what I have yeen. Unless that changed, the response can be modified

LisoUseInAIKyrios commented 3 hours ago

I find 7.0x useful to turn a video into a speed up time lapse.

Maybe the new menu is a simple feature flag and can be forced off if the old custom speed menu is desired.

ReVanced / revanced-patches