ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.66k stars 302 forks source link

bug: YTM Update pop-up #4040

Open nightznero opened 6 hours ago

nightznero commented 6 hours ago

Bug description

I was updated my YTM from v7.03.52 with RVP v4.15.0 to (YTM same version) RVP v5.2.1 and now i got inside the app popup with information that my version is old and requires to update. Before since today there wasn't any popup Image

Error logs

Solution

1.Changing suggested version to newer 2.Disabling this popup 3.Support still older versions

Additional context

No response

Acknowledgements

cyberboh commented 6 hours ago

Just update it, do repatch again with latest version available. Simple.

nightznero commented 6 hours ago

App works fine(for now as tested) its just popup that app requires update but there is no need to update,its Cosmetic

cyberboh commented 6 hours ago

App works fine(for now as tested) its just popup that app requires update but there is no need to update,its Cosmetic

Then it is not a bug since you can manually update it.

LisoUseInAIKyrios commented 6 hours ago

If someone has time and cares about YT Music, then please find the lowest version of YT Music that does not show this upgrade message.

nightznero commented 5 hours ago

Just update it, do repatch again with latest version available. Simple.

For some reason suggested version is lowe e.x Permanente Shuffle doesn't work. Im not going above suggested version,the reason why i post issue with it. If this version is not fine anymore it shouldn't be suggested or stopped supported ┐(-。-;)┌

cyberboh commented 5 hours ago

@nightznero Permanent shuffle was constrained to last working version caused it does not work with latest YTM available. You can ignore version checking in manager and use latest YTM available (for now 7.29.51) it will work.

@LisoUseInAIKyrios he just using old 7.03.52, we can using latest version without any issue

LisoUseInAIKyrios commented 5 hours ago

Permanent shuffle was limited to target 7.03 because the patch doesn't seem to work anymore.

nightznero commented 5 hours ago

@nightznero Permanent shuffle was constrained to last working version caused it does not work with latest YTM available. You can ignore version checking in manager and use latest YTM available (for now 7.29.51) it will work.

Shuffle was working on RV v4.15.0. I know how to change versions,i belive there are a lot newbies that needs advices and its nice n kind from You but i no need help here but on fixing issues inside the patch,as mentioned before i gave 3solutions to fix it. I think(maybe wrong) not only me uses older versions of YTM To test,debug,fix i can use RVX that requires polish,but RV is solid project and i m using Stable/suggeted version to have the lowers bugs as possible and have free mind when using them

LisoUseInAIKyrios commented 5 hours ago

I don't use YT Music and I never will. I'm going off other users reports that permanent shuffle is broken. https://github.com/ReVanced/revanced-patches/issues/3505

Edit: another developer found that permanent shuffle is still broken with 7.15

Permanent shuffle could be version bumped just to increment the recommended version (even though it's likely still broken).