ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.4k stars 277 forks source link

bug(YouTube): Remember Playback Speed changes behaves different with playlists and opening videos in the same player #52

Open Randomuser457 opened 11 months ago

Randomuser457 commented 11 months ago

Bug description

Disabling "Remember Playback Speed changes" from revanced >video
dosent work on 1.0x. if its switched off and i change playback speed to anything, it'll remember it in next video. but if default playback speed is anything other than 1.0x , and i change playback speed in video, it'll go back to default speed in next video but only if default speed is not set to 1.0x.

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

LisoUseInAIKyrios commented 11 months ago

Your instructions are a bit confusing.

List the exact steps to reproduce the issue.

Randomuser457 commented 11 months ago

1) revanced>video>default playback speed> set to 1.0x and and turned off "Remember Playback Speed Changes".

Now if i open any video and from top right corner i change playback speed to anything e.g. 1.5x and i switch to another video, that video will start with 1.5 playback speed even when i have turned off that setting.

but

2) when i have set revanced>video>default playback speed> anything other than 1.0x lets say 1.25x and do the same process above of switching to 1.5x from inside the video and then open another video, it'll start with 1.25x.

so the bug is in 1.0x speed. I've sent video in discord server support section and my discord tag is (monank)

oSumAtrIX commented 11 months ago

From my tests, the override speed hook is not being called when the speed is set to 1.0

LisoUseInAIKyrios commented 11 months ago

This is the behavior of stock YouTube.

Try with stock YouTube and you'll see:

Open a video, change the speed, then open a new video from inside the video player (ie: open a video from the suggested videos below the currently playing video), YouTube will retain the existing playback speed until you close the player.

But if you close the video player, then open a new video, the playback speed will be back to 1.0

The playback speed patch is altering this behavior, but only if the speed on video load is not 1.0x.

Some ways to resolve this would be picking one of:

  1. set the speed back back to 1.0x for this situation. This would alter the stock YouTube behavior, for better or worse, and playlists would be affected the most.
  2. do not reset the playback speed to the default, if the playback speed is not 1.0x when the video loads (would match stock YouTube behavior, but may not be what some users want)
  3. Make no changes, and accept the existing patch behavior as-is.
Randomuser457 commented 11 months ago

yea looks like its issue of original YouTube.

So can it be fixed in revanced or it'll stay like this and can't do anything?

oSumAtrIX commented 11 months ago

There's three options in the previous comment