search

ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.43k stars 282 forks source link

bug(YouTube - Custom branding): ReVanced specific splash screen does not show up on devices with Android 11 or older #584

Open xDARKxDEVILx opened 1 year ago

xDARKxDEVILx commented 1 year ago

Type

Cosmetic

Bug description

Using YouTube version 18.23.35 and latest patches version and custom branding patch, the splash screen logo is the YouTube logo instead of the new ReVanced logo

Steps to reproduce

1- using YouTube version 18.23.35 2- using patches version 2.184.0 3- using custom branding patch and most of the default patches 4- patch the apk successfully 5- the splash screen logo is not changed

Relevant log output

None

Screenshots or videos

No response

Solution

No response

Additional context

Android 11 MIUI 12.1 Xiaomi mi 9t

Please don't close and ask to edit with what more info is needed

Acknowledgements

LisoUseInAIKyrios commented 1 year ago

It's because you're using Android 11.

Android 12 and 13 work no problem with the custom splash screen, but the manifest and splash screen logic is different for android 11 and older and it ignores the patch splash screen changes.

I'm sure it can be fixed, if anyone cared enough to take the time and figure out what needs to be changed.

oSumAtrIX commented 1 year ago

I am aware of the splash screen not working on Android 11 and below and I know what is necessary to fix it, but its cumbersome to implement so I didn't do it.

xDARKxDEVILx commented 1 year ago

But i think a lot of users still use Android 11 and older still, so can you do it? 🥺🥺

LisoUseInAIKyrios commented 1 year ago

Eventually YouTube will restore the animated splash screen again (it's currently ab testing a replacement), and then the static ReVanced splash screen won't work anymore (at least, it won't work without additional changes).

From a time investment perspective, it would make more sense to wait until the new animated splash screen is restored and then revisit this. Otherwise any effort to fix cosmetics of older devices may be entirely for nothing when the static launch screen goes away.

xDARKxDEVILx commented 1 year ago

Eventually YouTube will restore the animated splash screen again (it's currently ab testing a replacement), and then the static ReVanced splash screen won't work anymore (at least, it won't work without additional changes).

From a time investment perspective, it would make more sense to wait until the new animated splash screen is restored and then revisit this. Otherwise any effort to fix cosmetics of older devices may be entirely for nothing when the static launch screen goes away.

Alright thanks for replying, it is not a big deal anyway, you guys have much more serious stuff to work on anyway

cyberboh commented 1 year ago

@xDARKxDEVILx don't use custom-branding patch, new splash screen should work.

xDARKxDEVILx commented 1 year ago

@xDARKxDEVILx don't use custom-branding patch, new splash screen should work.

If that is true, the logo would be the same as YouTube so not worth the trade for me but thanks for the help

cyberboh commented 1 year ago

@xDARKxDEVILx don't use custom-branding patch, new splash screen should work.

If that is true, the logo would be the same as YouTube so not worth the trade for me but thanks for the help

i don't think so, as i know, custom-branding just rename YouTube name to YouTube Revanced and changed its launcher icon to Revanced icon. correct me if i'm wrong.

xDARKxDEVILx commented 1 year ago

@xDARKxDEVILx don't use custom-branding patch, new splash screen should work.

If that is true, the logo would be the same as YouTube so not worth the trade for me but thanks for the help

i don't think so, as i know, custom-branding just rename YouTube name to YouTube Revanced and changed its launcher icon to Revanced icon. correct me if i'm wrong.

Yes and as i said i want the ReVanced "launcher icon" too, i don't think it is a good option for me

n1cKz1 commented 1 year ago

Not sure if i should create a new issue about this or not, but I myself am on Android 12 (MIUI 13) and custom splash screen still isn't working

LisoUseInAIKyrios commented 1 year ago

@n1cKz1 Is it showing the new animated splash screen? If so that is a different issue.

n1cKz1 commented 1 year ago

@n1cKz1 Is it showing the new animated splash screen? If so that is a different issue.

No, it shows this one

Screenshot_2023-10-05-05-54-15-031_app.revanced.android.youtube.jpg

LisoUseInAIKyrios commented 1 year ago

MIUI is heavily customized. Because it's still loading the Android 11 splash screen, then it likely still uses the Android 11 launch screen code. So it's the same issue as other Android 11 devices.

n1cKz1 commented 9 months ago

Now that YouTube is seemingly done rolling out the new splash screen globally can this be revisited?

oSumAtrIX commented 9 months ago

YouTube replaced it with an animation instead of an icon, therefor this issue and the respective code to change the splash icon lost their purpose. On older devices, YouTube may show the splash icon though.

n1cKz1 commented 9 months ago

Idk if it's the case for everyone, but for me it still shows the icon for like half a second or more before the animation is played

oSumAtrIX commented 9 months ago

That could be part of the animation.

LisoUseInAIKyrios commented 9 months ago

I think there is two separate animations. The first is the YT icon morphing shape and it uses the Android 12 animated splash screen feature. Android 11 and earlier would not display this and instead shows a static icon.

And the second animation is the horizontal progress bar, which I think is custom YT code and also why it's seen on all devices.