ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.04k stars 239 forks source link

feat (YT Music/`Match Player Color`): Match Minimized Player Color to Full-Screen Player Color #606

Closed ILoveOpenSourceApplications closed 1 year ago

ILoveOpenSourceApplications commented 1 year ago

Application

YT Music

Issue

The YouTube Music app offers a dynamic and immersive music listening experience. However, the current disparity in color schemes between the minimized player and the full-screen player can disrupt the visual continuity for users. Aligning the color of the minimized player with that of the full-screen player will enhance the app's aesthetic appeal and provide a more seamless user experience.

Patch

I propose a patch to synchronize the color of the minimized player with that of the full-screen player when playing music in the YouTube Music app. By harmonizing these elements, users will benefit from a visually cohesive interface that enhances engagement and enjoyment of their music.

Motivation

  1. Visual Continuity: Matching the colors of the minimized and full-screen players creates a unified design language, providing users with a seamless transition between different views of the app.

  2. Enhanced Aesthetics: A synchronized color scheme elevates the overall look and feel of the YouTube Music app, making it more visually appealing and modern.

  3. User Engagement: Consistent colors across player views contribute to a more immersive user experience, encouraging users to interact more with the app's features and controls.

  4. Accessibility: A harmonized color scheme improves accessibility for users with visual impairments or color vision deficiencies, ensuring clear and distinguishable elements.

Acknowledgements

oSumAtrIX commented 1 year ago

The motivation is too overgeneralized. The feature does not bring any additional benefit. The miniplayer changes the color to the amoled background which is matching

ILoveOpenSourceApplications commented 1 year ago

The motivation is too overgeneralized. The feature does not bring any additional benefit. The miniplayer changes the color to the amoled background which is matching

Currently there is a transition from album color to gray color of nav bar. By implementing this patch request that animation would be removed and the minimized player will have the touch of the full screen album color as well. This is followed in Spotify. Screenshot_20230713-181606~2

ILoveOpenSourceApplications commented 1 year ago

Video showing the issue mentioned above:

https://github.com/revanced/revanced-patches/assets/117499019/b0501f91-42a7-4946-81f8-610389367685

Notice how it stays the same color as album style, then reverts to the nav bar color. By implementing this patch, that transition will be more fluid.

oSumAtrIX commented 1 year ago

The transition is a minor inconvenience and should ve reported to YouTube. The color fading to gray matches the background of the current screen. This is fine too

ILoveOpenSourceApplications commented 1 year ago

Considering how minimized player is something related to the full screen player, I feel it should follow the same theme as the full screen player, transitioning between both feels fluid and the user can enjoy the change in color of the album art in the minimized player as well. And if the user is someone who like minimalistic looks, they can choose not to enable this option leaving them with the black themed minimized player.

oSumAtrIX commented 1 year ago

Again, this is too much of a small inconvenience. If that was a valid patch request, why not request to change the button size by 2px? Your issue is insignificant.

ILoveOpenSourceApplications commented 1 year ago

Everything is a small inconvenience. And having to face such small inconsistencies everyday is the issue. Why add sponsorblock when the user can just skip away, it's just multiple taps. Why add hide buttons, when you can just not touch the buttons/ just don't look at them.

oSumAtrIX commented 1 year ago

No, sponsored segments is not a small inconvenience and neither are ads for example. Coloring the minimized playback on the other hand is an insignificant issue

ILoveOpenSourceApplications commented 1 year ago

I never mentioned hide ads as a small inconvenience. Sponsorblock on the other hand, I do feel like it. It can always be skipped, unlike ads which are forced. Every other patches ReVanced has is just for conveniences. For each person their own personal need. It's not like we do a polling before implementing a patch.

oSumAtrIX commented 1 year ago

I never mentioned hide ads as a small inconvenience

Here is an implicit metion from you of it:

Everything is a small inconvenience.

SponsroBlock is not a minor inconvenience because you have to consume the video before you are able to know that it's a sponsored segment.

It's not like we do a polling before implementing a patch.

A patch request remains a request at the end of the day. Technically I can even stop doing that and close any request that I personally don't like, though I provide requestors the ability to reason their requests and consider them if they are reasonable. Coloring the minimized playback is too insignificant

ILoveOpenSourceApplications commented 1 year ago

I never mentioned hide ads as a small inconvenience

Here is an implicit metion from you of it:

Everything is a small inconvenience.

I never said it specifically. When I said everything I didn't think that ads as an app element will be considered.

SponsroBlock is not a minor inconvenience because you have to consume the video before you are able to know that it's a sponsored segment.

Most sponsored segments starts with mentioning that it's sponsored, I don't see why one needs to watch it fully to understand that it's a sponsored segment.

It's not like we do a polling before implementing a patch.

A patch request remains a request at the end of the day. Technically I can even stop doing that and close any request that I personally don't like, though I provide requestors the ability to reason their requests and consider them if they are reasonable. Coloring the minimized playback is too insignificant

Yes and as an user I appreciate that the patch requests are being considered. But shooting it down as too insignificant can not be justified. If mass requires the same and appreciates it then it isn't insignificant.

oSumAtrIX commented 1 year ago

I never said it specifically. When I said everything I didn't think that ads as an app element will be considered.

Everything means everything and everything will be considered.

Most sponsored segments starts with mentioning that it's sponsored, I don't see why one needs to watch it fully to understand that it's a sponsored segment.

Firstival, most means not all. Second sponsorblock is able to block more than just sponsored segments.

But shooting it down as too insignificant can not be justified.

It is justified though. I explained above why it was closed and "why" is a justification.

If mass requires the same and appreciates it then it isn't insignificant.

I don't see mass asking for this

ILoveOpenSourceApplications commented 1 year ago

I don't see mass asking for this

Wouldn't letting this patch request open can only those who wants this can show their support? If not they'll have to open their own individual patch request which can also be taken down for similar reasons.

ILoveOpenSourceApplications commented 1 year ago

Anyway, I feel this patch implementation would be good UI addition which YouTube should have added but hasn't and I requested for the same here. If it's not that much significant, well let the issue remain closed

oSumAtrIX commented 1 year ago

I don't see mass asking for this

Wouldn't letting this patch request open can only those who wants this can show their support? If not they'll have to open their own individual patch request which can also be taken down for similar reasons.

No, the status about an issue doesn't change anything other than that it stops beint considered by us. If people have interest, they can react to this issue then you can come back to it at a later time