ReVanced / revanced-patches

🧩 Patches for ReVanced
https://revanced.app
GNU General Public License v3.0
2.44k stars 284 forks source link

feat(X / Twitter): Get Back Twitter Bird #67

Closed monefiera closed 5 months ago

monefiera commented 11 months ago

Feature description

A patch to revert the ugliest X brand back to the beloved Twitter.
LarryOnX LSPosed module is flawed in that it can't log in from no login statement.
I know I can revert it by rewriting some codes in the res directory, but I haven't had ability to make patcher of this...

These are methods I found after months of research and analysis to return this apk.

①Replace all capital "X " with "Twitter" in res\values(-Country Code)\strings.xml.

②All "post" word replace to "tweet" in res\values(-Country Code)\strings.xml (if it's possible)

③In the following internal file, replace "dynamicColorGray1100" to "@color/twitter_blue".

④These files contain ugly "X" logo vector data. Replace this with the version 9.98.0-release-0's code.

⑤(edit 2024/01/08)Elon even went further in his misdeed by altering the birdcage. You can replace the vector file here to restore the original.

⑥The webp in these drawable-hdpi and others also contain logos that should be modified. However, I think it won't matter much.

Motivation

Many users seem to avoid the ugly "X," and in fact there are extensions such as Control Panel for Twitter and Twitter UI Customizer that revert changes made to the web version.
I crave this feature on mobile and I'm actually using apk(modified by me), but a patch function would make this much easier to achieve.

Acknowledgements

monefiera commented 11 months ago

https://github.com/ReVanced/revanced-patches/issues/543

cyberboh commented 11 months ago

Complicated patches

aubymori commented 10 months ago

This should definitely be intregrated, as older versions of the app, including the very last one to have Twitter branding, recently broke and now will not show quote tweets at all.

aubymori commented 10 months ago

Also, @monefiera, consider re-uploading your APK on a file sharing site that isn't complete shit.

monefiera commented 10 months ago

@aubymori OK, I put the link here using a different uploader as I already make newer version (10.26.0) that does the same thing! This includes not only design changes, but also the addition of a mod by the great therealswak. https://gofile.io/d/4ah7KL

kazimmt commented 8 months ago

①Replace all capital "X " with "Twitter" in res\values(-Country Code)\strings.xml.

It is the most important thing I think.

There are many words like EXAMPLE, & more with Capital X

This is just an example for you. I've checked string.xml, you can't just replace all capital X with Twitter

Same goes for post also.

monefiera commented 8 months ago

①Replace all capital "X " with "Twitter" in res\values(-Country Code)\strings.xml. It is the most important thing I think.

There are many words like EXAMPLE, & more with Capital X

This is just an example for you. I've checked string.xml, you can't just replace all capital X with Twitter

Same goes for post also.

This is true, and I understood that rewriting all the strings would be difficult to process (that's why I wrote "if possible" in the POST section). Also, it turns out that changing to Twitter will also crash if we are not careful (it will not start if the values of google_api_key and google_crash_reporting_api_key are rewritten). Currently, we believe that renaming the app and restoring the design would be optimal. By the way, patches to achieve this is under development and I hope it will be integrated into this patch.

monefiera commented 7 months ago

This is an addendum to my previous post. In strings, there are items called google_api_key and google_crash_reporting_api_key, which contain an uppercase X. Changing this will cause the app to crash. Since this is a value that does not change with version upgrades, it would be easy to patch to replace X→Twitter if only a workaround is provided here. However, according to apkmirror, the app is available in 41 languages, and replacing all of them is obviously not practical.

aubymori commented 7 months ago

/(?<=^| )X(?=$| )/g? or something like that

oSumAtrIX commented 5 months ago

Over time, a lot of feature requests have been made, which is why I am closing some according to the contribution guidelines:

Requests can be accepted or rejected at the discretion of maintainers of ReVanced Patches

This feature request has been closed for one or more of the following reasons:

Regardless, anyone who comes across this feature request can PR it. Thanks for the feature request!