search

ReVanced / revanced-website

🌐 Website for ReVanced
https://revanced.app
GNU General Public License v3.0
280 stars 43 forks source link

fix: don't hardcode any links #138

Closed oSumAtrIX closed 10 months ago

oSumAtrIX commented 12 months ago

About

Currently, the footer hardcodes a list of social links. Similar issues in other places might exist.

Solution

Where possible, the API response should be used, where not possible a site configuration should be used as described in #137

zalnaRs commented 12 months ago

What is the api endpoint to get the socials?

oSumAtrIX commented 12 months ago

It should be currently present in the API repo. No public API doc is present yet. I'd say introduce the abstraction in the websites API classes & mock until then. Take #137 into consideration if necessary.

oSumAtrIX commented 12 months ago

@alexandreteles may be able to give an insight into this

alexandreteles commented 12 months ago

@alexandreteles may be able to give an insight into this

It is going to be api.revanced.app/v2/socials returning, for example:

{
  "socials": {
    "website": "https://revanced.app",
    "github": "https://github.com/revanced",
    "twitter": "https://twitter.com/revancedapp",
    "discord": "https://discord.gg/revanced",
    "reddit": "https://www.reddit.com/r/revancedapp",
    "telegram": "https://t.me/app_revanced",
    "youtube": "https://www.youtube.com/@ReVanced"
  }
}