Open Ushie opened 2 months ago
Real problem is that semver doesn't handle versions with leading 0s, and as such, labels those as invalid.
I couldn't figure out why these lines of code were here
To sort all the invalid versions to the start I think
What do you mean? The version is not according to semver specs.
Yes, yet we rely on the semver
package for sorting the items.
That should be removed then
removed
Are you saying sorting the supported versions should be entirely disabled? Or to replace it instead of entirely removing it?
I am saying the version should not be parsed as semver
Well, please explicitly state if you mean it should be parsed another way (most likely) or not parsed (literal interpretation of what you're saying)
There's no requirement for sorting via the version name
How else do you propose we sort it?
As stated in my previous comment, there is no requirement to sort by version name at all.
Are you saying we should use the sorting provided by the backend instead? If so, that sounds like you should make a separate issue for that
The backend does not specify any sorting and is considered to be random. No issue is necessary
What I'm saying is if you want to remove the current sorting, you should discuss that in a place like an issue first.
Since it's discussed here with a clear solution, that won't be necessary anymore and this PR can be repurposed to solve both issues at once
I couldn't figure out why these lines of code were here, or if removing them would effect anything, but it seems to work perfectly fine Closes #238