ReaCoMa / ReaCoMa-2.0

ReaCoMa 2.0
GNU General Public License v3.0
37 stars 2 forks source link

Save parameters as presets? #1

Closed frescoalfredo closed 3 months ago

frescoalfredo commented 3 years ago

I'm primarily using HPSS right now and although it works very well, finding the right settings is a matter of trial-and-error. I'd like to request, if possible, that the script allows saving of all parameters as presets which can be recalled. (Currently I'm taking screen shots of the script window as reference for settings that work well for a given audio source type, which is better than nothing.) Since the script window recalls the previous settings used (as long as Reaper isn't closed), I could fumble my way through changing parameters and then once I've gotten a result I like, I could open the window again and save a preset. Naming of the presets would be helpful too.

Another request, which might be too far beyond the scope of what you planned: allowing auditioning of the script's results before outputting WAV files (for a single item that's chosen, anyway). This would make parameter selection significantly faster.

There are some Reascript GUI toolkits and API extensions to take advantage of, if you are considering this kind of thing. I can link you to them if you're not aware of them already.

jamesb93 commented 3 years ago

Hey James, thanks for the feedback and for using ReaCoMa! As it stands I basically have no time to develope ReaCoMa right now. There is a branch for ReaCoMa 2, where I am rewriting someone elses gui library (for HIDPI support) in order to make the interface better and to allow capabilities such as you described with auditioning results without outputting files. That however will always be underpinned by making a file, as the command line tools cannot generate audio buffers or work in memory. If you want go fast, I recommend you set the output of reacoma (available in the config) to a good temp location and just trash it when you are done if you are worried about space bloat. One of the design considerations was to use takes so you can easily do A/B then undo if you dont like the result.

I'll let you know how it goes, but honestly its not looking like a new version would happen even in the next year, given how behind I am with other stuff due to the pandemic. Thanks nonetheless though, its other peoples interest that gives me motivation to work on it.

jamesb93 commented 3 years ago

Something like this could be great...

https://forum.cockos.com/showthread.php?p=2416501

jamesb93 commented 3 years ago

This is in progress on a new branch now:

https://github.com/jamesb93/ReaCoMa/tree/reacoma2

Huge overhaul with new GUI stuff...

you might be interested @JamesPeters667

frescoalfredo commented 3 years ago

Thanks for the mention. However I tried running it (fluid-hpss.lua in particular) and it returned:

imgui_helpers.lua:4: 'reaper.ImGui_CreateContext': expected 2 arguments maximum

I have RealmGUI 0.5.1, and flucoma-cli 1.0.0.RC1b (Linux binaries).

(ReaCoMa 1.6.2 works as expected with flucoma-cli 1.0.0.RC1b, anyway.)

jamesb93 commented 3 years ago

Ah yeah, currently its broken as I was building it all out on the 0.4.1 version of ReaImGui. I'm in the process of updating to the new API of 0.5.1 :) Shouldnt be too long.

On Thu, 1 Jul 2021, at 9:09 PM, JamesPeters667 wrote:

Thanks for the mention. However I tried running it (fluid-hpss.lua in particular) and it returned:

imgui_helpers.lua:4: 'reaper.ImGui_CreateContext': expected 2 arguments maximum

I have RealmGUI 0.5.1, and flucoma-cli 1.0.0.RC1b (Linux binaries).

(ReaCoMa 1.6.2 works as expected with flucoma-cli 1.0.0.RC1b, anyway.)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jamesb93/ReaCoMa/issues/9#issuecomment-872518780, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFKURVIQZRQDMLEJZTI4GDTVTDRLANCNFSM424CCOUQ.

jamesb93 commented 3 years ago

This is now sorted upstream but I will await a released version:

https://github.com/cfillion/reaimgui/commit/25857158a8f915f939106b88cfe6989b3f648800

frescoalfredo commented 3 years ago

I'm using Linux so that's not a problem for me, at least I don't think.

I noticed something else though. With the ReaCoMa 2 (downloaded a couple minutes ago), and RealmGUI 0.5.1, when I run a script (fluid-hpss.lua again), a window pops up which...takes the entire Reaper window (except the main menu) and has no way to exit. :) I have to close Reaper and restart it so I can see any part of the GUI. Even if I use an action to start a new project, the ReaCoMa window takes up the whole screen.

jamesb93 commented 3 years ago

Yeah, this is part of the API changes I need to adapt to.

jamesb93 commented 3 years ago

Just as a heads up, I will soon be splitting the repository up into 2.0 and non 2.0 stuff:

https://github.com/ReaCoMa/ReaCoMa-2.0

jamesb93 commented 3 years ago

There is a new release of ReaImGui. If you wanted to try out the installation to find any warts/issues that would be amazing! It's working my end though so far :)

frescoalfredo commented 3 years ago

It seems to work well, from the little bit of testing I did with HPSS. It's nice to move sliders around and not have to enter values especially with commas between them on a single line. I suppose it'd be nice if the hints ("?") would provide a bit more useful information about all parameters, since a lot of this is guesswork as I'm doing it. But if the original documentation isn't clear enough about it (from what I've seen), that probably won't happen. :)