search

ReachFive / fake-smtp-server

Fake SMTP Server for email testing
https://www.npmjs.com/package/fake-smtp-server
MIT License
194 stars 78 forks source link

Bugfix: Mail command failed: 421 Error: too many unauthenticated commands #10

Closed sourabh8003 closed 6 years ago

sourabh8003 commented 6 years ago

This PR will fix the issue of too many unauthenticated commands while sending emails through automated test cases.

jcdelmas commented 6 years ago

Thank you for your PR.

Are you sure that a startup option is necessary to solve this issue ?

I think that maxAllowedUnauthenticatedCommands attribute can just be set to a big value (disabling does not seem well supported).

sourabh8003 commented 6 years ago

@jcdelmas : No, startup option is not necessary to solve the issue but if we can pass the attribute value for maxAllowedUnauthenticatedCommands from the startup commands instead of hard coded value that will allow us to pass our own numbers to allowed commands.

jcdelmas commented 6 years ago

Ok, but I'd rather keep this project as simple as possible. So, if there is not a clear use case for adding this option, I'd rather have the value hard coded.

sourabh8003 commented 6 years ago

@jcdelmas : That's fine, I'll update my PR. Thanks!

sourabh8003 commented 6 years ago

@jcdelmas : PR has been updated.