search

ReachFive / fake-smtp-server

Fake SMTP Server for email testing
https://www.npmjs.com/package/fake-smtp-server
MIT License
194 stars 78 forks source link

Allow SMTP Auth, ignore STARTTLS and added Dockerfile #14

Closed edmund-wagner closed 5 years ago

edmund-wagner commented 6 years ago

I'v set up an autobuild for the docker image at dockerhub. You can test the changes by running:

docker pull edmundwagner/fake-smtp-server docker run -it -d -P -e MAX=1000 -p 25:1025 -p 2580:1080 edmundwagner/fake-smtp-server

cheers Edmund

jcdelmas commented 6 years ago

Hello,

Thank you for this work.

I have a question : is there any specific reason why you did not use the npm install -g fake-smtp-server in the Dockerfile ?

Thanks,

Jean-Christophe

edmund-wagner commented 6 years ago

Hello,

Thank you for this work.

I have a question : is there any specific reason why you did not use the npm install -g fake-smtp-server in the Dockerfile ?

Thanks,

Jean-Christophe

I'm using intermediate containers to reduce the size of the final image and it is easier to copy the "local" production build from that intermediate container.

jcdelmas commented 6 years ago

Thank you for your response. However, the reason is still not clear for me because the version from NPM is supposed to be optimized. Given the increased complexity, I don't see the point of "rebuilding" the app in the Dockerfile, instead of installing it from NPM.

edmund-wagner commented 6 years ago

Thank you for your response. However, the reason is still not clear for me because the version from NPM is supposed to be optimized. Given the increased complexity, I don't see the point of "rebuilding" the app in the Dockerfile, instead of installing it from NPM.

Ah I see, i made some changes i wanted to test and have on dockerhub (my accoundt etc.) if you create an automated image build yourself, you can of course change that to an install from npm.

But imho its a bit easier to find files to quick fix etc. when i can see where they are put via dockerfile.

ameliabradley commented 5 years ago

There are a lot of bundled changes in this pull request. If we can unbundle them it might make it easier to get changes merged in.

For instance, this PR fixes #15, but it's currently on hold because of an unrelated Docker enhancement.

edmund-wagner commented 5 years ago

@leebradley Its a fork I forgot to close the pull request.