Adding Basic auth support to fake-smtp-server

ReachFive / fake-smtp-server

Fake SMTP Server for email testing

https://www.npmjs.com/package/fake-smtp-server

MIT License

192 stars 81 forks source link

Closed jainsahab closed 6 years ago

jainsahab commented 6 years ago

applying basic auth to the web interface using --auth USERNAME:PASSWORD format.
all the exposed API will continue to work as expected by passing credentials as part of the request. curl -v http://localhost:1080/api/emails -u username:password

jcdelmas commented 6 years ago

Thanks for the PR.

Can you just revert the first commit ? This code is useful in react dev mode (where the origins are not the same: http://localhost:3000 and http://localhost:1080), and when the server is not installed on the domain's root path (e.g. http://example.com/fake-smtp-server).

jainsahab commented 6 years ago

@jcdelmas my bad, I didn't consider that scenario. I have reverted that now. Let me know if you have any other feedbacks.

jainsahab commented 6 years ago

@jcdelmas any updates on the above?