search

React-Dominicana / dominicans-who-code-react

Dominicans Who Codes in React ⚛️
https://festive-pike-7fadeb.netlify.com/
MIT License
15 stars 10 forks source link

What about JSS and Material UI #16

Open amaurygomez opened 4 years ago

amaurygomez commented 4 years ago

Hi everyone, I look into the dependencies we are using reactstrap and for style css. But someone apply scss is a good ones or better option like pure css . But what is your opinion to apply jss and material ui components. The focus is copy the site with the same style or implements betters looks and new things?

GianCastle commented 4 years ago

I love Google Material Design guidelines. ❤️

This is an education and Just4Fun project. Instead of adding another dependency on the package.json for a Material Design look and feel, how about implementing the Material Design Standard for our components with SCSS and a bit of JavaScript?

mecm1993 commented 4 years ago

Agree with @GianCastle. However, I believe @amaurygomez proposal could be taken into consideration later on. As the project is for education and fun, it would be great to implement different styles and then compare the two results.

amaurygomez commented 4 years ago

Agree with both , implement the Material Design Standard and differents styles and then compare for best practice , less code, time , etc !

GianCastle commented 4 years ago

How will we handle different styles within the same application? If we gonna do that, we must need to define the acceptance criteria.

I've been watching Indians Who Design website and it looks great (it's also made with React)

We can start this just with cloning the same styles in our project and finish some UI features like the filter

I also see the're using a backend. Since we have no backend, just a .json file we need to filter by tags in the frontend. If you guys think this is not a good idea, then we can do something simple (doing a Custom Post Type in Wordpress and consuming it with their Wordpress API)

amaurygomez commented 4 years ago

I can help in the night with a backend in ExpressJs or NextJs, and with can implement that on Hekoru, or any AWS EC2 free tier , any suggestion is accepted ~!

mecm1993 commented 4 years ago

How will we handle different styles within the same application? If we gonna do that, we must need to define the acceptance criteria.

I've been watching Indians Who Design website and it looks great (it's also made with React)

We can start this just with cloning the same styles in our project and finish some UI features like the filter

I also see the're using a backend. Since we have no backend, just a .json file we need to filter by tags in the frontend. If you guys think this is not a good idea, then we can do something simple (doing a Custom Post Type in Wordpress and consuming it with their Wordpress API)

To handle different styles, we can create an additional branch for each style, for example.

amaurygomez commented 4 years ago

To handle different styles, we can create additional branches for each style, for example.

Or have one folder with the style implementation name , and in the view folder a main file with any switcher method and on the views can change the styles. :bulb: