search

React-Dominicana / dominicans-who-code-react

Dominicans Who Codes in React ⚛️
https://festive-pike-7fadeb.netlify.com/
MIT License
15 stars 10 forks source link

what about add a Modal? #20

Open HarysVizcaino opened 5 years ago

HarysVizcaino commented 5 years ago

Open a modal when someone click on a developer and show more information about the developer, this information could be about the developer's github, example: repositories, contributions, stars etc.

mecm1993 commented 5 years ago

In my opinion, this could overload the content. There is a GitHub link already for the developer if someone would like to know more about that particular developer activity and projects.

However, I think a popup that shows the contributions chart when hovering the GitHub link could be a nice feature, but at the same time, I think it does not relate to the purpose of the site.

GianCastle commented 5 years ago

I like the idea, it gives more value to the site and also more fun to the project. However...

Right now we have just a JSON file. This JSON file just contains a Github URL to the current user (if the user provides one)

This is totally possible on my mind with this method.

mecm1993 commented 5 years ago

I like the idea, it gives more value to the site and also more fun to the project. However...

Right now we have just a JSON file. This JSON file just contains a Github URL to the current user (if the user provides one)

This is totally possible on my mind with this method.

  • If the coder provides a Github link, then we extract the user from the URL
  • Next, we call the Github API and extract the user.
  • Finally, we map the info and render the component.

If this is going to be taken into consideration, then you have to think as well that some coder does not work on GitHub only. It is possible, that the coder works in GitLab or Bitbucket, and the coder does not have anything in GitHub to show.

@GianCastle, you mentioned If the coder provides a GitHub link, and if he/she doesn't? Currently, that field is not mandatory, therefore it would not behave the same for everyone.