Support for seconds and milliseconds in gantt

React9k / react-timeline-9000

React Timeline

http://react-timeline-9000.s3-website-ap-southeast-2.amazonaws.com/

MIT License

288 stars 36 forks source link

Support for seconds and milliseconds in gantt #196

Closed Iorda closed 2 years ago

Iorda commented 4 years ago

I'm a collaborator with @cristian-spiescu. The gantt doesn't go beyond minutes and you cannot zoom out after going past this point. 2020-09-11 14_55_34-React Timeline 9000

This issue has been fixed in my branch. I also added a new snap variable called "snap"(see problems below)

Problems

Since the snap was titled "snapMinutes" , I added a new var called "snap". "snapMinutes" still exist to not damage current projects, but the new variable takes seconds. The problem I had is, that I could not get it to below seconds, because of rounded pixel calculations. Meaning, even if i gave it 500 ms to snap, it would go to 0,7s, because it was rounded.

kashifshamaz21 commented 3 years ago

@lilfolr @marklawlor I would also like to have this feature, as we have events tracked at "seconds" granularity too. Can we look at merging the PR sent by @Iorda for adding support for it? Thanks in advace.

lilfolr commented 3 years ago

Added comments to the PR. Just need to update the unit tests & some variable names and I think its good to go

cristian-spiescu commented 3 years ago

I think we discovered a bug introduced by this feature. The pixelsPerSecond() doesn't exist any more. Hence now drag & resize don't work any more!

We'll take a look at this and provide a fix.

cristian-spiescu commented 3 years ago

The PR that we've just mentioned fixes the above issue.

cristian-spiescu commented 2 years ago

Thanks Leighton for the merge. Can you also close this issue?