Move onItemEnter/onItemLeave listeners onto the items.

React9k / react-timeline-9000

React Timeline

http://react-timeline-9000.s3-website-ap-southeast-2.amazonaws.com/

MIT License

288 stars 36 forks source link

Move onItemEnter/onItemLeave listeners onto the items. #206

Closed marklawlor closed 3 years ago

marklawlor commented 3 years ago

Proposed Change:

Move onItemEnter/onItemLeave listeners onto the items.

Add onRowEnter/onRowLeave props

Fixes: #205 205

Change type

[x] Bugfix
[x] New feature

Checklist

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

marklawlor commented 3 years ago

I'm confused why the existing code toggles this.selecting on hover events. I would assume that you wouldn't want these calbacks to fire when selecting. I keep it as it, but it seems incorrect. Can someone please clarify the reasoning.