search

ReactFinland / site

React Finland site
https://react-finland.fi/
16 stars 17 forks source link

Improve OpenGraph Tags #35

Open okonet opened 6 years ago

okonet commented 6 years ago

Right now Ken's image is being displayed:

2018-01-30 at 09 22

bebraw commented 6 years ago

Good point. What's a good way to test this? What to display instead?

okonet commented 6 years ago

No idea. Needs research. Please post here when found

okonet commented 6 years ago

I'd display the logo (probably will need a separate asset)

bebraw commented 6 years ago

Ok, logo is simple to pull off. It's just a reference through the EJS template and maybe some copy bit.

okonet commented 6 years ago

Related: https://github.com/gatsbyjs/gatsby/issues/2829

bebraw commented 6 years ago

Ok. Note that I'm not using react-helmet yet.

okonet commented 6 years ago

Probably you'll need it anyway to control document title etc. or how it's done now?

Re: image — probably it needs to be an image of a specific size. If you can find any guides, please post here.

bebraw commented 6 years ago

Here: https://github.com/ReactFinland/site/blob/master/templates/page.ejs#L14 .

I agree, it's in a spec somewhere.

okonet commented 6 years ago

Also see https://www.npmjs.com/package/metaimages

okonet commented 6 years ago

and https://www.npmjs.com/package/open-graph-meta