search

ReactFinland / site

React Finland site
https://react-finland.fi/
16 stars 17 forks source link

Creating the countdown in the header #53

Closed Scoombe closed 6 years ago

Scoombe commented 6 years ago

I have had a go at addressing issue #26. I need some pointers on the style of the change, also this is my first time looking at react so any help there would be nice.

bebraw commented 6 years ago

Deploy preview for react-finland processing.

Built with commit f5bf9133d1b01a4b50b3d30221324e89a24ed930

https://app.netlify.com/sites/react-finland/deploys/5a9955e6fd0efa40570f3a64

bebraw commented 6 years ago

That's a great start!

Check pages/for-attendees.js on how to wrap the component to an Interactive container. After that the counter works also in the production version. This is a small limitation of the static site generator and I might fix this later. But for now we have to wrap it.

@manpenaloza @okonet Can you provide some guidance on the visual outlook? Preview here.

bebraw commented 6 years ago

Inspiration: https://dribbble.com/tags/countdown_timer . Something along https://dribbble.com/shots/3825256-Daily-UI-challenge-014-Countdown-timer would look cool perhaps. I would do it horizontal like that but with tuned style.

manpenaloza commented 6 years ago

nice one!

Horizontal look could be a good choice, wireframed sth for further implementation. what do you think? react-finl-countdown

bebraw commented 6 years ago

@manpenaloza That looks great to me! We can use the font we already have. The layout is just 👍 .

Scoombe commented 6 years ago

@manpenaloza Looks good! @bebraw What steps should be taken now?

bebraw commented 6 years ago

@Scoombe Would you be comfortable porting to the proposed layout? You can also try Interactive. Let me know if you get stuck and I can manage the rest. 👍

Scoombe commented 6 years ago

@bebraw I would be, what's the best way to do this? Inline css in the react component or adding to the existing css files? I might not get time to do this until Friday if that's ok.

bebraw commented 6 years ago

@Scoombe No rush. Maybe separate CSS like for now. I might integrate a css-in-js solution (Emotion) later.

okonet commented 6 years ago

Can we move the counter below the tagline?

Scoombe commented 6 years ago

@bebraw @manpenaloza I have made some changes, but I need some help with the css. Could you help with this. Thanks.

okonet commented 6 years ago

I can help you with CSS after you resolve the comments.

Scoombe commented 6 years ago

@okonet I have made the changes you have requested. Thanks, for pointing me in the right direction, I was having problems with the concept of when react was calling the reload.

bebraw commented 6 years ago

Merged! Thanks a lot for your contribution @Scoombe. Are you coming to the conference?

okonet commented 6 years ago

Nice work!