search

ReactFinland / site

React Finland site
https://react-finland.fi/
17 stars 17 forks source link

Feature/axe a11y critical issues #59

Closed J-Kallunki closed 5 years ago

J-Kallunki commented 5 years ago

Not taking a stance on how the mobile should be zoomable or not (and how it would look like): initial-scale=1.0, minimum-scale=1.0

Closes #27

bebraw commented 5 years ago

Deploy preview for react-finland processing.

Built with commit e47d3887506049c41f062afefd1d6f76b0ff3887

https://app.netlify.com/sites/react-finland/deploys/5c0ec67740e2a47254c33928

bebraw commented 5 years ago

Great, thanks.

Maybe we skip initial-scale=1.0, minimum-scale=1.0 for now as sometimes people like to zoom on mobile. What's the recommendation?

J-Kallunki commented 5 years ago

The the zooming has been disabled before this and stil now on. (Uups I mentioned to comment with the part ’maximum-scale= 1.0’ that is same as the initial.) I could test and make another PR for the zooming to be enabled