search

ReactKit / SwiftState

Elegant state machine for Swift.
MIT License
904 stars 93 forks source link

Swift 3.0 compatible? #49

Closed aperritano closed 7 years ago

phillco commented 8 years ago

It's obviously an untenable solution long-term but I found as a Pods user, running Xcode's conversion wizard plus one manual fix (a ++ to a += 1) allowed it to work in a Swift 3.0 project.

phillco commented 8 years ago

It would be nice to add @discardableResult to the mutator functions, though -- otherwise you get lots of spurious "result is unused" warnings on the addRoute and <- calls.

inamiy commented 8 years ago

I created swift/3.0 branch now. Please check https://github.com/ReactKit/SwiftState/commit/8d2b4cadd3f57d0a376f500dd3d35459b8c13116.

TODO

froimer commented 7 years ago

Please, can you publish Swift 3 to master? Thanks.

afinlayson commented 7 years ago

Can you publish 3.0 to a new Pod version, as per usual practice. I can create a pullrequest if you'll accept it.

samskiter commented 7 years ago

Is this swift 3.1 compatible too?

inamiy commented 7 years ago

Sorry for late response. I will close this old issue.

@samskiter Sorry, Swift 3.1 is skipped and it now supports 4.0 in #59 .