search

ReactKit / SwiftState

Elegant state machine for Swift.
MIT License
904 stars 93 forks source link

Swift 4.0 support #59

Closed adamyanalunas closed 7 years ago

adamyanalunas commented 7 years ago

Hi there! The current swift/3.0 branch doesn't work on projects that target Swift 4.0. This PR is a result of running Xcode 9 migrators, cleaning up new warnings, and fixing making one value public instead of internal.

There's no swift/4.0 branch yet so I had to target swift/3.0. If you create a 4.0 branch I'll change the PR's target.

inamiy commented 7 years ago

Hi @adamyanalunas , thank you for PR!

Would you mind:

By the way, Circle CI free plan is no longer available, so the change is actually not necessary.

adamyanalunas commented 7 years ago

@inamiy requested changes have been made.

By changing the targeted branch to swift/4.0 there are some additional commits. I'm pretty sure that's not from my fork but let me know and I'll see if I can clean them up.

inamiy commented 7 years ago

@adamyanalunas Thank you for the fixes! Overall looks perfect 😄 Sorry that I was pointing swift/4.0 to wrong swift/2.0 by mistake. That's why additional commit is displayed in GitHub. (I don't know why it still exists after I changed to swift/3.0)

Anyway, thank you for contribution, and I will merge this! I will also invite you as collaborator, so you are free to push further commits (I can review some) or leave if you aren't interested :)

apps4everyone commented 7 years ago

@inamiy @adamyanalunas Thank you for the fixes!