search

ReactTraining / react-history

Manage session history with React
266 stars 23 forks source link

Update to use prop-types #22

Closed CheshireSwift closed 6 years ago

CheshireSwift commented 7 years ago

Switched to use the prop-types module, rather than React.PropTypes, as required for compatibility with React 16+

CheshireSwift commented 7 years ago

Tests fail on CI, but they also fail if I do a clean clone of this repo and run locally; seems unrelated?

Rendez commented 6 years ago

This React wrapper is awesome, but we can't use it because of lack of React 16 compat. Could you please merge this?

mjackson commented 6 years ago

Thanks for the PR, @CheshireSwift! I'll look into the test failures and cut a new release as soon as I get them sorted 😅