search

ReactTraining / react-media

CSS media queries for React
MIT License
2.44k stars 115 forks source link

Problem with SSR + query #126

Closed tstirrat15 closed 5 years ago

tstirrat15 commented 5 years ago

I've been seeing this error when testing out next: 

    TypeError: Cannot convert undefined or null to object
        at Function.keys (<anonymous>)

I've got a repro in a test, so I'll see what I can do to fix and then push a PR.

tstirrat15 commented 5 years ago

JK. This is addressed in 11792078661da9219cf7ee5fff25fb0ab4c20225, but that's not released on NPM yet. @edorivai can you release that and I can test it in my project?

edorivai commented 5 years ago

Yeah, I'll actually cut a prerelease of v1 now that it should be backwards compatible!

edorivai commented 5 years ago

Alright, react-media@next should now resolve to 1.10.0-alpha.0, take a look!