search

ReactTraining / react-media

CSS media queries for React
MIT License
2.44k stars 115 forks source link

DropdownList hover should change rw-state-focus element #133

Closed brandoncc closed 5 years ago

brandoncc commented 5 years ago

Hi, thanks for this really nice project. I find it very weird that when you open a DropdownList, the first element is always selected (with the obvious border styling by default), and hovering has no effect on it. A traditional select dropdown will let you change the "active" option either with the keyboard or hovering an option, and each continues where the other left off. Your widget considers those two things completely separate.

Is there a reason for this, or was it merely an oversight?

brandoncc commented 5 years ago

In the meantime, I did this for anyone else who might have this concern:

.my-dropdown-parent:hover
  .rw-list-option.rw-state-focus
    border-color: transparent

Just know that it doesn't actually fix the problem, as the state-focus'd element is just not shown in a border while hovering over the element.

edorivai commented 5 years ago

Hi @brandoncc! Are you sure this is the correct repo for posting your issue?

brandoncc commented 5 years ago

Ha, not it isn't. I have no idea how I did that. Sorry @edorivai !!