search

ReactTraining / react-media

CSS media queries for React
MIT License
2.44k stars 115 forks source link

Part of #150 : add typings for useMedia #151

Closed abenhamdine closed 4 years ago

abenhamdine commented 4 years ago

see https://github.com/ReactTraining/react-media/issues/150

works fine for me :

image

image

image

remark : with single query, we have to use the generic to type the result :

image

if not, result is typed unknown, TS seems unable to pick the first signature

image

edorivai commented 4 years ago

Interesting, it actually does seem to infer the correct function signature for me: image

abenhamdine commented 4 years ago

ah weird FWIW I use ts 3.8.3

edorivai commented 4 years ago

Yeah I'm using the same version.

edorivai commented 4 years ago

Should be available at react-media@next or react-media@2.0.0-rc.1 btw