search

ReactVision / starter-kit

React Native project setup with Viro 🚀
MIT License
127 stars 90 forks source link

Add missing android installation instructions #65

Closed robertjcolley closed 4 months ago

robertjcolley commented 5 months ago

Updates the starter kit for android. I must have missed this while updating the starter kits! Sorry everyone 😄

TODO

Closes #61

deepak-jha-kgp commented 5 months ago

Crashed on Android Emulator. Could be this -> https://github.com/viromedia/viro/issues/269

deepak-jha-kgp commented 5 months ago

App does not crash on physical Android Device but getting a black screen. Seems camera tracking is unavailable. Device is Oneplus 9R, app has required permissions.

agallardoysla commented 5 months ago

we need to add: <uses-feature android:name="android.hardware.camera.ar" />

robertjcolley commented 5 months ago

we need to add: <uses-feature android:name="android.hardware.camera.ar" />

@agallardoysla - Adding this got things working?

Crashed on Android Emulator. Could be this -> https://github.com/viromedia/viro/issues/269

@deepak-jha-kgp - We don't support the android emulator at the moment, and there's a high chance it never will be fully supported since the emulator and simulators are only as supported as Google/Apple want them to be. For example, my mac Studio currently is unable to run AR features on an emulator (arm, not x86). Would an acceptable alternative be to render a blank view with some text like "AR is not supported on [Emulators|Simulators]" that didn't crash?

GLandres commented 5 months ago

@robertjcolley yes, this fix Black screen. But I have a crashsing bug with imagenTracking function (android)

robertjcolley commented 5 months ago

@robertjcolley yes, this fix Black screen. But I have a crashsing bug with imagenTracking function (android)

Are you using the App.tsx that comes with the starter kit? Or have you started building with the project?

robertjcolley commented 5 months ago

@robertjcolley yes, this fix Black screen. But I have a crashsing bug with imagenTracking function (android)

@GLandres Are you using the App.tsx that comes with the starter kit? Or have you started building with the library?

GLandres commented 5 months ago

@robertjcolley thanks for your answer. is starterkit, I added a simple imageTracking.

robertjcolley commented 5 months ago

@robertjcolley thanks for your answer. is starterkit, I added a simple imageTracking.

Gotcha. It sounds like that's a separate issue. This PR is to fix the issue with the starter kit "out of the box." I encourage you to create an issue in ViroReact with a small example, if possible. I've got a bunch of stability issues to sort through right now and I can add that to the list for the next patch release with your help! 😄

rajamuthukumaran-geekyants commented 5 months ago

we need to add: <uses-feature android:name="android.hardware.camera.ar" />

Hi @robertjcolley @agallardoysla, I tried this but I am still getting black screen on my physical device Samsung Tab S7+ which is an ARCore-supported device and has required permission. However, I didn't see any error in the console. In the past, I only experienced this issue in non-ARCore-supported devices.

KowalewskiPawel commented 5 months ago

we need to add: <uses-feature android:name="android.hardware.camera.ar" />

Hi @robertjcolley @agallardoysla, I tried this but I am still getting black screen on my physical device Samsung Tab S7+ which is an ARCore-supported device and has required permission. However, I didn't see any error in the console. In the past, I only experienced this issue in non-ARCore-supported devices.

The same here on Nothing Phone 1, tried various setups, configs, available in this repo but nothing worked out. It's always a black screen.