ReactVision / viro

ViroReact: The AR and VR library for React Native 📳💙💛🤍💚
MIT License
1.31k stars 149 forks source link

Invalid UlAccessibilityTraits "tablist' #116

Closed francois-pasquier closed 4 months ago

francois-pasquier commented 2 years ago

Requirements:

Please go through this checklist before opening a new issue

Environment

Please provide the following information about your environment:

  1. Development OS: Mac
  2. Device OS & Version: iOS 15.3.1
  3. Device(s): iPhone SE 2020

Description

When starting the app I am getting this error:

Invalid UlAccessibilityTraits "tablist'., should
be one of: (
adjustable,
allowsDirectInteraction,
button,
disabled,
frequentUpdates,
header,
image,
key,
link,
none,
pageTurn,
plays,
search,
selected,
startsMedia,
summary,
text
)
RCTConvertEnumValue

IMG_DDE6CF343233-1

It happens on 2.23.0 and 2.22.0

Reproducible Demo

Let us know how to reproduce the issue. Include a code sample, screen capture, video recording. The more information you provide, the better we can support you.

robertjcolley commented 2 years ago

Can you provide a reproducible demo? maybe fork the starter kit and share with us here so I can look into it more?

francois-pasquier commented 2 years ago

So this was due to using @react-navigation/bottom-tabs.

I fixed this by using patch-packages and I patched bottom-tabs to replace tablist to button as pointed out by an issue on stackoverflow.

Again, I wonder if the issue should be closed as what I did to fix it shouldn't needed.

Please note this doesn't happen on Android, only in iOS from what I remember.

bigxalx commented 2 years ago

Could you please explain in more detail, or point me in the direction of how exactly you fixed this? I've tried your suggested fix by changing tablist to button in node_modules/@react-navigation/bottom-tabs/src/views/BottomTabBar.tsx. I can't find any other occurances of tablist, but still I get the same error. IMG_4E30E84F558B-1

Sunil-prajapati commented 2 years ago

please follow this link it will work 100% https://stackoverflow.com/questions/71119108/invalid-uiaccessibilitys-tablist-error-after-installing-react-native-vector-ic

darringrove commented 2 years ago

I confirmed that this error exists after adding react-viro. This work around did resolve the issue temporarily, but what is the root cause and permanent solution?