ReactVision / viro

ViroReact: The AR and VR library for React Native πŸ“³πŸ’™πŸ’›πŸ€πŸ’š
MIT License
1.3k stars 150 forks source link

Video with alpha channel #230

Closed andresteves closed 2 months ago

andresteves commented 9 months ago

Requirements:

Please go through this checklist before opening a new issue

Environment

Please provide the following information about your environment:

  1. Development OS: Mac
  2. Device OS & Version: iOS 15 and Android 13
  3. Version: ViroReact 2.23.0 and React Native 0.66.5
  4. Device(s): What device(s) are you are seeing the issue on iPhone XR and OnePlus 8 Pro

Description

So the issue is around the video with alpha channel not working as expected even when adding chromaFiltering. I tried using react-native-video to reproduce the video and it works with alpha channel out of the box but I cannot put him inside a Viro component.

Reproducible Demo

Top one is ViroVideo with chromaKeyFilteringColor: '#55004508', and bottom one is from react-native-video IMG_1997

My question is can we had any component other than Viro inside a ViroNode, I tried and gave out an error about RTCView.

andresteves commented 9 months ago

Any one has a suggestion or opinion on how to fix or proceed?

andresteves commented 9 months ago

Is it possible add react-native-video component inside a Viro component?

andresteves commented 2 months ago

Closing as it is now working with latest version of Viro.