search

ReactVision / viro

ViroReact: The AR and VR library for React Native 📳💙💛🤍💚
MIT License
1.36k stars 157 forks source link

Fix ViroImage crash on Android due to deprecated/missing java libraries. #258

Closed Avtrkrb closed 7 months ago

Avtrkrb commented 8 months ago

Updated android/viro_bridge/build.gradle to include a few missing libraries & updated all fresco libraries to 3.1.3. Ran gradlew command in prepare_release.sh to generate fresh builds of viro_bridge-release.aar & react_viro-release.aar. These changes introduce a fix for bugs in the issue #257. Locally compiled, linked with expo-starter-kit-typescript & tested the changes.

Some libraries do not compile against compileSdkVersion & targetSdkVersion set to 30, hence bumped it to 31 to get it to compile & generate viro_bridge-release.aar.

Avtrkrb commented 8 months ago

@robertjcolley @cjmcassar Please review & approve this PR.

jasj commented 7 months ago

please!!!!!

Avtrkrb commented 7 months ago

The changes from this PR have been included in this PR. Hence closing this PR.