ReactVision / viro

ViroReact: The AR and VR library for React Native 📳💙💛🤍💚
MIT License
1.3k stars 150 forks source link

Crash on Android due to fresco class not found #290

Open andresteves opened 1 month ago

andresteves commented 1 month ago

Requirements:

Please go through this checklist before opening a new issue

Environment

Please provide the following information about your environment:

  1. Development OS: Mac,
  2. Device OS & Version: What Android OS version (7.0, 8.0, etc.) is your device running on? Android 13
  3. Version: ViroReact 2.41.1 and React Native 0.68.7
  4. Device(s): What device(s) are you are seeing the issue on (i.e. iPhone X, Samsung Note 8, etc) One plus 8

Description

After upgrading Viro to the latest version I get whenever I try to start viro on the app

java.lang.NoClassDefFoundError: Failed resolution of: Lcom/facebook/imagepipeline/image/BaseCloseableStaticBitmap;
at com.viromedia.bridge.utility.ImageDownloader$1.onNewResultImpl(ImageDownloader.java:156)
linear[bot] commented 1 month ago

XR-202 Crash on Android due to fresco class not found

tranminhnhat1005 commented 1 month ago

Same issue +1

doranteseduardo commented 3 weeks ago

Please share more context so I can help you.

tranminhnhat1005 commented 3 weeks ago

In my case, I changed the version to 2.23.3 and the problem was solved.

"@viro-community/react-viro": "2.23.3"

Same issue +1

andresteves commented 3 weeks ago

@doranteseduardo it happens with those versions above on original post and when I start Viro on the app. It happens when deploying on an Android 13 device.

andresteves commented 3 weeks ago

@tranminhnhat1005 Yes that version works but latest version updates android libraries and I believe is causing it to happen on the version of RN I originally said. I have updated RN to 0.73.0 and it does not happens anymore.

tranminhnhat1005 commented 3 weeks ago

@tranminhnhat1005 Yes that version works but latest version updates android libraries and I believe is causing it to happen on the version of RN I originally said. I have updated RN to 0.73.0 and it does not happens anymore.

Yes, I have some projects with different react-native versions, and which project using >=0.73.0 worked. I tried to finding the reason and found it:

https://reactnative.dev/blog/2023/12/06/0.73-debugging-improvements-stable-symlinks#other-breaking-changes:~:text=Android%3A%20Major%20bump%20of%20Fresco%20to%203.0%20(%2338275).