Changed if isinstance(level_of_theory, Level)

calvinp0 commented 1 year ago

Adjusted line 770 to now check if the instance is a Level rather than if level_of_theory is None

codecov[bot] commented 1 year ago

Codecov Report

Merging #619 (61ccc07) into main (b34b2fa) will increase coverage by 0.00%. The diff coverage is 0.00%.

:exclamation: Current head 61ccc07 differs from pull request most recent head 771faeb. Consider uploading reports for the commit 771faeb to get more accurate results

@@           Coverage Diff           @@
##             main     #619   +/-   ##
=======================================
  Coverage   73.02%   73.03%           
=======================================
  Files          99       99           
  Lines       26175    26175           
  Branches     5481     5481           
=======================================
+ Hits        19115    19117    +2     
+ Misses       5698     5697    -1     
+ Partials     1362     1361    -1

Impacted Files	Coverage Δ
arc/scheduler.py	`20.20% <0.00%> (ø)`

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

alongd commented 1 year ago

Looks like we took care of all specific levels, but not of level_of_theory: https://github.com/ReactionMechanismGenerator/ARC/pull/602/commits/1e30fbf86ded2b8c03cd40d0a729c88308be3b36

@Laxzal, please squash

ReactionMechanismGenerator / ARC

Changed if isinstance(level_of_theory, Level) #619

Codecov Report