search

ReactionMechanismGenerator / ARC

ARC - Automatic Rate Calculator
https://reactionmechanismgenerator.github.io/ARC/index.html
MIT License
43 stars 21 forks source link

Added 'is not None' to if conditions #626

Closed calvinp0 closed 1 year ago

calvinp0 commented 1 year ago

In the original issue, when a self.variable =0, then the if self.variable: was not met in theas_dict() function found in the script: https://github.com/ReactionMechanismGenerator/ARC/blob/ba4f5b9aa8cb1b3ab8d6135e0d1e25ee10f5cc76/arc/job/adapter.py#L824

codecov[bot] commented 1 year ago

Codecov Report

Merging #626 (df49754) into main (be28706) will increase coverage by 0.00%. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #626   +/-   ##
=======================================
  Coverage   73.02%   73.02%           
=======================================
  Files          99       99           
  Lines       26179    26179           
  Branches     5482     5482           
=======================================
+ Hits        19116    19118    +2     
+ Misses       5700     5699    -1     
+ Partials     1363     1362    -1
Impacted Files Coverage Δ
arc/job/adapter.py 40.50% <0.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

alongd commented 1 year ago

I added one comment, please rebase and squash