Closed kfir4444 closed 1 year ago
Do you think we should bump numpy more? See https://github.com/ReactionMechanismGenerator/ARC/pull/517
Merging #652 (8d1aac8) into main (a56b0df) will increase coverage by
0.00%
. The diff coverage is75.00%
.
@@ Coverage Diff @@
## main #652 +/- ##
=======================================
Coverage 73.12% 73.13%
=======================================
Files 99 99
Lines 26284 26277 -7
Branches 5497 5497
=======================================
- Hits 19221 19217 -4
+ Misses 5700 5698 -2
+ Partials 1363 1362 -1
Impacted Files | Coverage Δ | |
---|---|---|
arc/settings/settings.py | 89.01% <ø> (-0.47%) |
:arrow_down: |
arc/utils/wip.py | 90.00% <75.00%> (+5.38%) |
:arrow_up: |
... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Do you think we should bump numpy more? See #517 Probably not possible for now, we would need to update python: ├─ numpy 1.22.0 is installable with the potential options │ ├─ numpy 1.22.0 would require │ │ └─ python >=3.9,<3.10.0a0 , which can be installed; │ ├─ numpy 1.22.0 would require │ │ └─ python >=3.10,<3.11.0a0 , which can be installed; │ └─ numpy 1.22.0 would require │ └─ python >=3.8,<3.9.0a0 , which can be installed; └─ python 3.7 is uninstallable because there are no viable options ├─ python [3.7.0|3.7.1|...|3.7.9] conflicts with any installable versions previously reported; └─ python 3.7.1 would require └─ openssl >=1.1.1,<1.1.2.0a0 , which does not exist (perhaps a missing channel).
Are we clear to merge?
This PR contains two features:
@wip
decorator with a one that is not dependent on nosetests.