ReactionMechanismGenerator / ARC

ARC - Automatic Rate Calculator
https://reactionmechanismgenerator.github.io/ARC/index.html
MIT License
43 stars 21 forks source link

Call check_scan_job() also if the directed_scan_type is `None` #654

Closed alongd closed 1 year ago

alongd commented 1 year ago

A 1D rotor Job is defined with a directed_scan_type attribute of None if it's not a directed scan. We must also consider that in the condition before calling check_scan_job() in Scheduler

codecov[bot] commented 1 year ago

Codecov Report

Merging #654 (1185dbe) into main (d0b0e87) will decrease coverage by 0.06%. The diff coverage is 0.00%.

:exclamation: Current head 1185dbe differs from pull request most recent head 7e85792. Consider uploading reports for the commit 7e85792 to get more accurate results

@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
- Coverage   73.19%   73.14%   -0.06%     
==========================================
  Files          99       99              
  Lines       26303    26290      -13     
  Branches     5502     5500       -2     
==========================================
- Hits        19253    19229      -24     
- Misses       5687     5699      +12     
+ Partials     1363     1362       -1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
arc/scheduler.py 20.28% <0.00%> (-0.02%) :arrow_down:

... and 3 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more