ReactionMechanismGenerator / ARC

ARC - Automatic Rate Calculator
https://reactionmechanismgenerator.github.io/ARC/index.html
MIT License
42 stars 21 forks source link

Added solvation option to Orca job adapter #666

Closed alongd closed 8 months ago

alongd commented 1 year ago

Added SMD and PCM solvation types Note that the keywords here are for Orca 4 and not Orca 5, this should still be fixed

Tests added

codecov[bot] commented 1 year ago

Codecov Report

Merging #666 (f5d8e4d) into main (6b51ce5) will decrease coverage by 0.30%. The diff coverage is 94.73%.

:exclamation: Current head f5d8e4d differs from pull request most recent head 1f1b930. Consider uploading reports for the commit 1f1b930 to get more accurate results

@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
- Coverage   73.52%   73.23%   -0.30%     
==========================================
  Files          99       99              
  Lines       26602    26378     -224     
  Branches     5542     5516      -26     
==========================================
- Hits        19559    19317     -242     
- Misses       5673     5692      +19     
+ Partials     1370     1369       -1     
Flag Coverage Δ
unittests 73.23% <94.73%> (-0.30%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
arc/job/adapters/orca_test.py 100.00% <100.00%> (ø)
arc/job/adapters/orca.py 48.20% <80.00%> (+1.18%) :arrow_up:

... and 29 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

alongd commented 1 year ago

@Lilachn91, what's the status of this PR? The errors in the tests seem trivial to fix

Lilachn91 commented 11 months ago

@alongd I fixed the tests, should be fine. Note it's a temporary fix until I figure out parallelization in Atlas. After I'll edit the adapter to work also with solvation on Orca 5 and test it, we can merge.

Thanks :)