Closed MichalKesl closed 1 year ago
Merging #669 (2fa44ba) into main (677169a) will decrease coverage by
0.32%
. The diff coverage is0.00%
.:exclamation: Current head 2fa44ba differs from pull request most recent head 5c19c89. Consider uploading reports for the commit 5c19c89 to get more accurate results
@@ Coverage Diff @@
## main #669 +/- ##
==========================================
- Coverage 73.48% 73.17% -0.32%
==========================================
Files 99 99
Lines 26488 26427 -61
Branches 5541 5535 -6
==========================================
- Hits 19466 19338 -128
- Misses 5659 5722 +63
- Partials 1363 1367 +4
Flag | Coverage Δ | |
---|---|---|
unittests | 73.17% <0.00%> (-0.32%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
arc/plotter.py | 27.64% <0.00%> (-0.13%) |
:arrow_down: |
... and 9 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Thanks for the contribution @MichalKesl! Great job! Maybe we can use this opportunity to talk about how to test this function?
thermo_parity_plots.pdf
Here is an example of the parity plot using this branch.
One important comment on that is the parenthesis should be using \left(
, \right)
, to make sure that they match the size of the \frac
that is inside them.
Also, I would have used \cdot
to represent multiplication in the denominator of the entropy units, to differentiate the mol
and K
Thanks! While we make the titles fancier, could you make H298 and S298 be something like \Delta H ^{298_K} _f}
?
@MichalKesl, thanks, looking good. Could you please clean the commit message/description and rebase on main?
Fixed the legend settings for the parity plot and changed the units and the title of the plot to be written in Latex.